Re: [Qemu-devel] [PATCH 0/2] nbd server: drop old-style negotiation

2018-10-04 Thread Richard W.M. Jones
On Thu, Oct 04, 2018 at 12:10:17PM +, Vladimir Sementsov-Ogievskiy wrote: > this is a bit more difficult and more overhead than option in Qemu.. But > I don't sure we should care about I think Eric's point is that dropping oldstyle in qemu-nbd isn't really a problem because nbdkit has no plan

Re: [Qemu-devel] [PATCH 0/2] nbd server: drop old-style negotiation

2018-10-04 Thread Vladimir Sementsov-Ogievskiy
03.10.2018 21:08, Eric Blake wrote: > On 10/3/18 12:59 PM, Vladimir Sementsov-Ogievskiy wrote: >> 03.10.2018 20:32, Eric Blake wrote: >> On 10/3/18 12:02 PM, Vladimir Sementsov-Ogievskiy wrote: >> It's unexpected behavior that without -x option qemu-nbd do old-style >> negotiation. Let's use "" as

Re: [Qemu-devel] [PATCH 0/2] nbd server: drop old-style negotiation

2018-10-03 Thread Eric Blake
On 10/3/18 12:02 PM, Vladimir Sementsov-Ogievskiy wrote: It's unexpected behavior that without -x option qemu-nbd do old-style negotiation. Let's use "" as a default name instead (as it is already done if tls is used) and therefore, drop old-style negotiation from Qemu NBD server. Vladimir Semen

Re: [Qemu-devel] [PATCH 0/2] nbd server: drop old-style negotiation

2018-10-03 Thread Richard W.M. Jones
FWIW I don't have anything to add - agree with what's been said already. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot

Re: [Qemu-devel] [PATCH 0/2] nbd server: drop old-style negotiation

2018-10-03 Thread Eric Blake
On 10/3/18 12:59 PM, Vladimir Sementsov-Ogievskiy wrote: 03.10.2018 20:32, Eric Blake wrote: On 10/3/18 12:02 PM, Vladimir Sementsov-Ogievskiy wrote: It's unexpected behavior that without -x option qemu-nbd do old-style negotiation. Let's use "" as a default name instead (as it is already done if

Re: [Qemu-devel] [PATCH 0/2] nbd server: drop old-style negotiation

2018-10-03 Thread Vladimir Sementsov-Ogievskiy
03.10.2018 20:32, Eric Blake wrote: On 10/3/18 12:02 PM, Vladimir Sementsov-Ogievskiy wrote: It's unexpected behavior that without -x option qemu-nbd do old-style negotiation. Let's use "" as a default name instead (as it is already done if tls is used) and therefore, drop old-style negotiation fro

Re: [Qemu-devel] [PATCH 0/2] nbd server: drop old-style negotiation

2018-10-03 Thread Eric Blake
On 10/3/18 12:02 PM, Vladimir Sementsov-Ogievskiy wrote: It's unexpected behavior that without -x option qemu-nbd do old-style negotiation. Let's use "" as a default name instead (as it is already done if tls is used) and therefore, drop old-style negotiation from Qemu NBD server. Oddly enough,

[Qemu-devel] [PATCH 0/2] nbd server: drop old-style negotiation

2018-10-03 Thread Vladimir Sementsov-Ogievskiy
It's unexpected behavior that without -x option qemu-nbd do old-style negotiation. Let's use "" as a default name instead (as it is already done if tls is used) and therefore, drop old-style negotiation from Qemu NBD server. Vladimir Sementsov-Ogievskiy (2): qemu-nbd: drop old-style negotiation