Re: [Qemu-devel] [PATCH 0/2] add pci-serial device.

2012-09-28 Thread Gerd Hoffmann
Hi, >> For pci-serial windows needs a "driver" (which is just a inf file, the >> driver itself is shipped by windows). So in that case it is easier to >> go with our own ids I think, as we can simply ship a inf file then. >> When picking the IDs of other cards, existing as real hardware, users

Re: [Qemu-devel] [PATCH 0/2] add pci-serial device.

2012-09-28 Thread Michael S. Tsirkin
On Wed, Sep 26, 2012 at 08:01:39AM -0500, Anthony Liguori wrote: > Gerd Hoffmann writes: > > > On 09/26/12 01:43, Anthony Liguori wrote: > >> Gerd Hoffmann writes: > >> > >>> Hi, > >>> > >>> Two patches, first split up serial.c a bit, > >>> then actually add the pci-based serial device. > >>

Re: [Qemu-devel] [PATCH 0/2] add pci-serial device.

2012-09-28 Thread Michael S. Tsirkin
On Thu, Sep 27, 2012 at 07:53:47AM +0200, Gerd Hoffmann wrote: > Hi, > > > Understood, but I'd really prefer a file in docs/. We should be > > rigorous about having formal specs for all of our paravirtual devices. > > The code shouldn't be the spec. > > Well, pci-serial and pci-bridge are *not

Re: [Qemu-devel] [PATCH 0/2] add pci-serial device.

2012-09-26 Thread Gerd Hoffmann
Hi, > Understood, but I'd really prefer a file in docs/. We should be > rigorous about having formal specs for all of our paravirtual devices. > The code shouldn't be the spec. Well, pci-serial and pci-bridge are *not* paravirtual devices. They follow a specification describing the programmin

Re: [Qemu-devel] [PATCH 0/2] add pci-serial device.

2012-09-26 Thread Anthony Liguori
Gerd Hoffmann writes: > On 09/26/12 01:43, Anthony Liguori wrote: >> Gerd Hoffmann writes: >> >>> Hi, >>> >>> Two patches, first split up serial.c a bit, >>> then actually add the pci-based serial device. >> >> The series looks good to me. A couple requests: >> >> 1) Could you add a spec d

Re: [Qemu-devel] [PATCH 0/2] add pci-serial device.

2012-09-25 Thread Gerd Hoffmann
Hi, >> The only reason I ask is whether this is something we can add >> new features to. I can't think of one off hand, but it can't >> hurt to work this out up front. > > Multiport e.g. (to save PCI slots). There was some proposal > recently to add a model of an real multiport PCI card, just

Re: [Qemu-devel] [PATCH 0/2] add pci-serial device.

2012-09-25 Thread Gerd Hoffmann
On 09/26/12 01:43, Anthony Liguori wrote: > Gerd Hoffmann writes: > >> Hi, >> >> Two patches, first split up serial.c a bit, >> then actually add the pci-based serial device. > > The series looks good to me. A couple requests: > > 1) Could you add a spec describing this new PCI device? Does

Re: [Qemu-devel] [PATCH 0/2] add pci-serial device.

2012-09-25 Thread Jan Kiszka
On 2012-09-26 01:43, Anthony Liguori wrote: > Gerd Hoffmann writes: > >> Hi, >> >> Two patches, first split up serial.c a bit, >> then actually add the pci-based serial device. > > The series looks good to me. A couple requests: > > 1) Could you add a spec describing this new PCI device? Do

Re: [Qemu-devel] [PATCH 0/2] add pci-serial device.

2012-09-25 Thread Anthony Liguori
Gerd Hoffmann writes: > Hi, > > Two patches, first split up serial.c a bit, > then actually add the pci-based serial device. The series looks good to me. A couple requests: 1) Could you add a spec describing this new PCI device? Doesn't need to be more than a couple paragraphs since the

[Qemu-devel] [PATCH 0/2] add pci-serial device.

2012-09-24 Thread Gerd Hoffmann
Hi, Two patches, first split up serial.c a bit, then actually add the pci-based serial device. cheers, Gerd Gerd Hoffmann (2): serial: split serial.c serial: add pci variant default-configs/pci.mak |2 + docs/pciserial.inf | 96 +++ hw/Makefile.