Re: [Qemu-devel] [PATCH 0/2] Make simpletrace work on Windows

2011-09-22 Thread hkran
On 09/20/2011 06:15 PM, Zhi Yong Wu wrote: On Tue, Sep 20, 2011 at 5:57 PM, Stefan Hajnoczi wrote: On Tue, Sep 20, 2011 at 05:05:45PM +0800, hkran wrote: On 09/09/2011 05:37 PM, Stefan Hajnoczi wrote: The 'simple' trace backend uses pthreads and does not work on Windows. These patches switc

Re: [Qemu-devel] [PATCH 0/2] Make simpletrace work on Windows

2011-09-20 Thread Avi Kivity
On 09/09/2011 12:37 PM, Stefan Hajnoczi wrote: The 'simple' trace backend uses pthreads and does not work on Windows. These patches switch from pthreads to glib so that the code builds on all platforms supported by glib. Only one thing I'm unhappy about: the simpletrace write-out thread used to

Re: [Qemu-devel] [PATCH 0/2] Make simpletrace work on Windows

2011-09-20 Thread Zhi Yong Wu
On Tue, Sep 20, 2011 at 5:57 PM, Stefan Hajnoczi wrote: > On Tue, Sep 20, 2011 at 05:05:45PM +0800, hkran wrote: >> On 09/09/2011 05:37 PM, Stefan Hajnoczi wrote: >> >The 'simple' trace backend uses pthreads and does not work on Windows.   >> >These >> >patches switch from pthreads to glib so that

Re: [Qemu-devel] [PATCH 0/2] Make simpletrace work on Windows

2011-09-20 Thread Stefan Hajnoczi
On Tue, Sep 20, 2011 at 05:05:45PM +0800, hkran wrote: > On 09/09/2011 05:37 PM, Stefan Hajnoczi wrote: > >The 'simple' trace backend uses pthreads and does not work on Windows. These > >patches switch from pthreads to glib so that the code builds on all platforms > >supported by glib. > > > >Only

Re: [Qemu-devel] [PATCH 0/2] Make simpletrace work on Windows

2011-09-20 Thread hkran
On 09/09/2011 05:37 PM, Stefan Hajnoczi wrote: The 'simple' trace backend uses pthreads and does not work on Windows. These patches switch from pthreads to glib so that the code builds on all platforms supported by glib. Only one thing I'm unhappy about: the simpletrace write-out thread used to

Re: [Qemu-devel] [PATCH 0/2] Make simpletrace work on Windows

2011-09-09 Thread Paolo Bonzini
On 09/09/2011 11:37 AM, Stefan Hajnoczi wrote: The 'simple' trace backend uses pthreads and does not work on Windows. These patches switch from pthreads to glib so that the code builds on all platforms supported by glib. Only one thing I'm unhappy about: the simpletrace write-out thread used to

[Qemu-devel] [PATCH 0/2] Make simpletrace work on Windows

2011-09-09 Thread Stefan Hajnoczi
The 'simple' trace backend uses pthreads and does not work on Windows. These patches switch from pthreads to glib so that the code builds on all platforms supported by glib. Only one thing I'm unhappy about: the simpletrace write-out thread used to block all signals. I have removed that code and