Re: [Qemu-devel] [PATCH 0/2] Make mixer emulation configurable at runtime

2013-08-28 Thread Jan Kiszka
On 2013-08-28 18:37, Markus Armbruster wrote: >>> 3. Why does CONFIG_MIXEMU exist? >>> >> I can post a patch for it (again) on top of these changes and >> see where it goes. If the default value of the "mixer" property stays >> off, malc's concerns mentioned elsewhere in this thread will be taken

Re: [Qemu-devel] [PATCH 0/2] Make mixer emulation configurable at runtime

2013-08-28 Thread Markus Armbruster
Bandan Das writes: > Markus Armbruster writes: > >> Bandan Das writes: >> >>> Currently, hda-codec mixer emulation can only be enabled by using the >>> "--enable-mixemu" option to configure at compile time. These patches add >>> the option to make it configurable at runtime as well. >>> >>> A

Re: [Qemu-devel] [PATCH 0/2] Make mixer emulation configurable at runtime

2013-08-28 Thread Bandan Das
Markus Armbruster writes: > Bandan Das writes: > >> Currently, hda-codec mixer emulation can only be enabled by using the >> "--enable-mixemu" option to configure at compile time. These patches add >> the option to make it configurable at runtime as well. >> >> An example usage could be a qemu

Re: [Qemu-devel] [PATCH 0/2] Make mixer emulation configurable at runtime

2013-08-28 Thread Gerd Hoffmann
Hi, > >> 2. Why do we bother providing these devices when CONFIG_MIXEMU off? > >> > >>Why would anyone want hda audio devices without a mixer? Why > >>wouldn't anyone who wants hda audio devices also want CONFIG_MIXEMU > >>enabled? > > > > It'll actually work just fine with HDA. T

Re: [Qemu-devel] [PATCH 0/2] Make mixer emulation configurable at runtime

2013-08-28 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >> Only pulse and the spice audio backends set VOICE_VOLUME_CAP. >> >> Impact on users isn't obvious to me. > > It offloads volume control to the audio backend, i.e. it will be done by > pulseaudio/spice-client instead of mixemu. > >> Questions (not just for y

Re: [Qemu-devel] [PATCH 0/2] Make mixer emulation configurable at runtime

2013-08-28 Thread Gerd Hoffmann
Hi, > Only pulse and the spice audio backends set VOICE_VOLUME_CAP. > > Impact on users isn't obvious to me. It offloads volume control to the audio backend, i.e. it will be done by pulseaudio/spice-client instead of mixemu. > Questions (not just for you, Bandan): > > 1. Why is CONFIG_MI

Re: [Qemu-devel] [PATCH 0/2] Make mixer emulation configurable at runtime

2013-08-28 Thread Paolo Bonzini
Il 28/08/2013 11:13, Markus Armbruster ha scritto: > 1. Why is CONFIG_MIXEMU off by default? > >We generally default optional code to "on", to avoid bit-rot. We >make exceptions only when the optional code is truly unwanted by a >clear majority of our users. Why would anyone want hda

Re: [Qemu-devel] [PATCH 0/2] Make mixer emulation configurable at runtime

2013-08-28 Thread Markus Armbruster
Bandan Das writes: > Currently, hda-codec mixer emulation can only be enabled by using the > "--enable-mixemu" option to configure at compile time. These patches add > the option to make it configurable at runtime as well. > > An example usage could be a qemu cmdline : > "-device hda-duplex,m

[Qemu-devel] [PATCH 0/2] Make mixer emulation configurable at runtime

2013-08-27 Thread Bandan Das
Currently, hda-codec mixer emulation can only be enabled by using the "--enable-mixemu" option to configure at compile time. These patches add the option to make it configurable at runtime as well. An example usage could be a qemu cmdline : "-device hda-duplex,mixer=(on/off)" although this is