Re: [Qemu-devel] [PATCH 0/2] Fix unused-but-set-variable warnings

2011-05-30 Thread Amit Shah
On (Mon) 30 May 2011 [15:56:28], Christophe Fergeau wrote: > On Mon, May 30, 2011 at 04:23:43PM +0530, Amit Shah wrote: > > You should keep From: as the same person, keep his Signed-off-by, add > > your Signed-off-by and mention what you have changed in the series. > > Hans's patches didn't have a

Re: [Qemu-devel] [PATCH 0/2] Fix unused-but-set-variable warnings

2011-05-30 Thread Christophe Fergeau
On Mon, May 30, 2011 at 04:23:43PM +0530, Amit Shah wrote: > You should keep From: as the same person, keep his Signed-off-by, add > your Signed-off-by and mention what you have changed in the series. Hans's patches didn't have a S-o-b. I can resend the same patches again with my S-o-b (I'm fine w

Re: [Qemu-devel] [PATCH 0/2] Fix unused-but-set-variable warnings

2011-05-30 Thread Amit Shah
On (Mon) 30 May 2011 [12:28:01], Christophe Fergeau wrote: > Hi, > > Here are Hans's patches split and with the various issues that were pointed > out fixed. I'm not sure how I'm supposed to handle acks, original author, > ... when reworking patches this way, let me know if I should proceed > diff

[Qemu-devel] [PATCH 0/2] Fix unused-but-set-variable warnings

2011-05-30 Thread Christophe Fergeau
Hi, Here are Hans's patches split and with the various issues that were pointed out fixed. I'm not sure how I'm supposed to handle acks, original author, ... when reworking patches this way, let me know if I should proceed differently. Christophe Christophe Fergeau (2): tcg: Fix unused-but-se