[Qemu-devel] [PATCH 0/2] Enable qemu block layer to not flush v2

2010-05-12 Thread Alexander Graf
Thanks to recent improvements, qemu flushes guest data to disk when the guest tells us to do so. This is great if we care about data consistency on host disk failures. In cases where we don't it just creates additional overhead for no net win. One such use case is the building of appliances in SUS

Re: [Qemu-devel] [PATCH 0/2] Enable qemu block layer to not flush

2010-05-12 Thread Jamie Lokier
Stefan Hajnoczi wrote: > On Wed, May 12, 2010 at 10:42 AM, Jamie Lokier wrote: > > Stefan Hajnoczi wrote: > >> Why add a nop AIO operation instead of setting > >> BlockDriverState->enable_write_cache to zero?  In that case no write > >> cache would be reported to the guest (just like cache=writeth

Re: [Qemu-devel] [PATCH 0/2] Enable qemu block layer to not flush

2010-05-12 Thread Stefan Hajnoczi
On Wed, May 12, 2010 at 10:42 AM, Jamie Lokier wrote: > Stefan Hajnoczi wrote: >> Why add a nop AIO operation instead of setting >> BlockDriverState->enable_write_cache to zero?  In that case no write >> cache would be reported to the guest (just like cache=writethrough). > > Hmm.  If the guest se

Re: [Qemu-devel] [PATCH 0/2] Enable qemu block layer to not flush

2010-05-12 Thread Jamie Lokier
Stefan Hajnoczi wrote: > Why add a nop AIO operation instead of setting > BlockDriverState->enable_write_cache to zero? In that case no write > cache would be reported to the guest (just like cache=writethrough). Hmm. If the guest sees write cache absent, that prevents changing the cache policy

Re: [Qemu-devel] [PATCH 0/2] Enable qemu block layer to not flush

2010-05-12 Thread Stefan Hajnoczi
Why add a nop AIO operation instead of setting BlockDriverState->enable_write_cache to zero? In that case no write cache would be reported to the guest (just like cache=writethrough). Stefan

Re: [Qemu-devel] [PATCH 0/2] Enable qemu block layer to not flush

2010-05-11 Thread Jamie Lokier
Anthony Liguori wrote: > There's got to be a better place to fix this. Disable barriers in your > guests? If only it were that easy. OS installs are the thing that this feature would most help. They take ages, do a huge amount of writing with lots of seeking, and if the host fails you're going

Re: [Qemu-devel] [PATCH 0/2] Enable qemu block layer to not flush

2010-05-10 Thread Anthony Liguori
On 05/10/2010 05:03 PM, Alexander Graf wrote: On 10.05.2010, at 23:59, Anthony Liguori wrote: On 05/10/2010 04:51 PM, Alexander Graf wrote: Thanks to recent improvements, qemu flushes guest data to disk when the guest tells us to do so. This is great if we care about data consistenc

Re: [Qemu-devel] [PATCH 0/2] Enable qemu block layer to not flush

2010-05-10 Thread Alexander Graf
On 10.05.2010, at 23:59, Anthony Liguori wrote: > On 05/10/2010 04:51 PM, Alexander Graf wrote: >> Thanks to recent improvements, qemu flushes guest data to disk when the guest >> tells us to do so. >> >> This is great if we care about data consistency on host disk failures. In >> cases >> wher

Re: [Qemu-devel] [PATCH 0/2] Enable qemu block layer to not flush

2010-05-10 Thread Anthony Liguori
On 05/10/2010 04:51 PM, Alexander Graf wrote: Thanks to recent improvements, qemu flushes guest data to disk when the guest tells us to do so. This is great if we care about data consistency on host disk failures. In cases where we don't it just creates additional overhead for no net win. One su

[Qemu-devel] [PATCH 0/2] Enable qemu block layer to not flush

2010-05-10 Thread Alexander Graf
Thanks to recent improvements, qemu flushes guest data to disk when the guest tells us to do so. This is great if we care about data consistency on host disk failures. In cases where we don't it just creates additional overhead for no net win. One such use case is the building of appliances in SUS