Re: [Qemu-devel] [PATCH 0/2] 3270 improvements

2017-09-28 Thread Halil Pasic
On 09/28/2017 05:19 PM, Cornelia Huck wrote: > On Wed, 20 Sep 2017 19:23:12 +0200 > Halil Pasic wrote: > >> Jason found some problems with 3270 which he traced down to insufficient >> output buffer size. I've looked into the underlying issue (and the >> relevant code) and I saw strange things.

Re: [Qemu-devel] [PATCH 0/2] 3270 improvements

2017-09-28 Thread Cornelia Huck
On Wed, 20 Sep 2017 19:23:12 +0200 Halil Pasic wrote: > Jason found some problems with 3270 which he traced down to insufficient > output buffer size. I've looked into the underlying issue (and the > relevant code) and I saw strange things. Among others an unreasonable > assert requiring the payl

Re: [Qemu-devel] [PATCH 0/2] 3270 improvements

2017-09-27 Thread Halil Pasic
On 09/21/2017 01:00 PM, Halil Pasic wrote: Are you planning to do some further work on 3270, btw? >>> I did not. I jumped in because of IDA, and because I did >>> not agree with increasing the buffer size to another arbitrary >>> an value (and essentially keep the bug). I hope the or

Re: [Qemu-devel] [PATCH 0/2] 3270 improvements

2017-09-21 Thread Halil Pasic
On 09/21/2017 12:48 PM, Cornelia Huck wrote: > On Thu, 21 Sep 2017 12:22:30 +0200 > Halil Pasic wrote: > >> On 09/21/2017 11:24 AM, Cornelia Huck wrote: >>> On Wed, 20 Sep 2017 19:23:12 +0200 >>> Halil Pasic wrote: >>> Jason found some problems with 3270 which he traced down to insuffi

Re: [Qemu-devel] [PATCH 0/2] 3270 improvements

2017-09-21 Thread Cornelia Huck
On Thu, 21 Sep 2017 12:22:30 +0200 Halil Pasic wrote: > On 09/21/2017 11:24 AM, Cornelia Huck wrote: > > On Wed, 20 Sep 2017 19:23:12 +0200 > > Halil Pasic wrote: > > > >> Jason found some problems with 3270 which he traced down to insufficient > >> output buffer size. I've looked into the un

Re: [Qemu-devel] [PATCH 0/2] 3270 improvements

2017-09-21 Thread Halil Pasic
On 09/21/2017 11:24 AM, Cornelia Huck wrote: > On Wed, 20 Sep 2017 19:23:12 +0200 > Halil Pasic wrote: > >> Jason found some problems with 3270 which he traced down to insufficient >> output buffer size. I've looked into the underlying issue (and the >> relevant code) and I saw strange things.

Re: [Qemu-devel] [PATCH 0/2] 3270 improvements

2017-09-21 Thread Cornelia Huck
On Wed, 20 Sep 2017 19:23:12 +0200 Halil Pasic wrote: > Jason found some problems with 3270 which he traced down to insufficient > output buffer size. I've looked into the underlying issue (and the > relevant code) and I saw strange things. Among others an unreasonable > assert requiring the payl

[Qemu-devel] [PATCH 0/2] 3270 improvements

2017-09-20 Thread Halil Pasic
Jason found some problems with 3270 which he traced down to insufficient output buffer size. I've looked into the underlying issue (and the relevant code) and I saw strange things. Among others an unreasonable assert requiring the payload of a ccw being less than some more or less arbitrary limit (