On Fri, 24 Jun 2011, Peter Maydell wrote:
> On 24 June 2011 15:50, wrote:
> > /* read xenstore entries */
> > if (blkdev->params == NULL) {
> > blkdev->params = xenstore_read_be_str(&blkdev->xendev, "params");
> > + if (blkdev->params != NULL)
> > + h = strchr(bl
On 24 June 2011 15:50, wrote:
> /* read xenstore entries */
> if (blkdev->params == NULL) {
> blkdev->params = xenstore_read_be_str(&blkdev->xendev, "params");
> + if (blkdev->params != NULL)
> + h = strchr(blkdev->params, ':');
> h = strchr(blkdev->param
From: Stefano Stabellini
When disk is a cdrom and the drive is empty the "params" node in
xenstore might be missing completely: cope with it instead of
segfaulting.
Signed-off-by: Stefano Stabellini
---
hw/xen_disk.c | 16 +++-
1 files changed, 11 insertions(+), 5 deletions(-)
d
Am 11.02.2011 13:59, schrieb Stefano Stabellini:
> On Fri, 11 Feb 2011, Kevin Wolf wrote:
>> Am 11.02.2011 13:38, schrieb Stefano Stabellini:
>>> When disk is a cdrom and the drive is empty the "params" node in
>>> xenstore might be missing completely: cope with it instead of
>>> segfaulting.
>>>
>
On Fri, 11 Feb 2011, Kevin Wolf wrote:
> Am 11.02.2011 13:38, schrieb Stefano Stabellini:
> > When disk is a cdrom and the drive is empty the "params" node in
> > xenstore might be missing completely: cope with it instead of
> > segfaulting.
> >
> > Signed-off-by: Stefano Stabellini
> >
> >
> >
Am 11.02.2011 13:38, schrieb Stefano Stabellini:
> When disk is a cdrom and the drive is empty the "params" node in
> xenstore might be missing completely: cope with it instead of
> segfaulting.
>
> Signed-off-by: Stefano Stabellini
>
>
> diff --git a/hw/xen_disk.c b/hw/xen_disk.c
> index 134ac
When disk is a cdrom and the drive is empty the "params" node in
xenstore might be missing completely: cope with it instead of
segfaulting.
Signed-off-by: Stefano Stabellini
diff --git a/hw/xen_disk.c b/hw/xen_disk.c
index 134ac33..e553c4c 100644
--- a/hw/xen_disk.c
+++ b/hw/xen_disk.c
@@ -577,