Re: [Qemu-devel] [PATCH] watchdog: 6300esb: add exit function

2016-11-29 Thread Markus Armbruster
Li Qiang writes: > 2016-11-29 18:49 GMT+08:00 Markus Armbruster : [...] >> Method exit() is deprecated, please use unrealize() in new code. >> >> [...] >> > > Hello, > > IIUC in the PCIDeviceClass definition, there is just an exit member not a > unrealize. > The DeviceClass has an unrealize membe

Re: [Qemu-devel] [PATCH] watchdog: 6300esb: add exit function

2016-11-29 Thread Li Qiang
2016-11-29 18:49 GMT+08:00 Markus Armbruster : > Li Qiang writes: > > > Hi > > > > 2016-11-29 16:39 GMT+08:00 Richard W.M. Jones : > > > >> On Mon, Nov 28, 2016 at 05:49:04PM -0800, Li Qiang wrote: > >> > From: Li Qiang > >> > > >> > When the Intel 6300ESB watchdog is hot unplug. The timer alloc

Re: [Qemu-devel] [PATCH] watchdog: 6300esb: add exit function

2016-11-29 Thread Markus Armbruster
Li Qiang writes: > Hi > > 2016-11-29 16:39 GMT+08:00 Richard W.M. Jones : > >> On Mon, Nov 28, 2016 at 05:49:04PM -0800, Li Qiang wrote: >> > From: Li Qiang >> > >> > When the Intel 6300ESB watchdog is hot unplug. The timer allocated >> > in realize isn't freed thus leaking memory leak. This pat

Re: [Qemu-devel] [PATCH] watchdog: 6300esb: add exit function

2016-11-29 Thread Li Qiang
2016-11-29 17:00 GMT+08:00 Richard W.M. Jones : > On Tue, Nov 29, 2016 at 04:56:55PM +0800, Li Qiang wrote: > > Hi > > > > 2016-11-29 16:39 GMT+08:00 Richard W.M. Jones : > > > > > On Mon, Nov 28, 2016 at 05:49:04PM -0800, Li Qiang wrote: > > > > From: Li Qiang > > > > > > > > When the Intel 6300

Re: [Qemu-devel] [PATCH] watchdog: 6300esb: add exit function

2016-11-29 Thread Richard W.M. Jones
On Tue, Nov 29, 2016 at 04:56:55PM +0800, Li Qiang wrote: > Hi > > 2016-11-29 16:39 GMT+08:00 Richard W.M. Jones : > > > On Mon, Nov 28, 2016 at 05:49:04PM -0800, Li Qiang wrote: > > > From: Li Qiang > > > > > > When the Intel 6300ESB watchdog is hot unplug. The timer allocated > > > in realize

Re: [Qemu-devel] [PATCH] watchdog: 6300esb: add exit function

2016-11-29 Thread Li Qiang
Hi 2016-11-29 16:39 GMT+08:00 Richard W.M. Jones : > On Mon, Nov 28, 2016 at 05:49:04PM -0800, Li Qiang wrote: > > From: Li Qiang > > > > When the Intel 6300ESB watchdog is hot unplug. The timer allocated > > in realize isn't freed thus leaking memory leak. This patch avoid > > this through addi

Re: [Qemu-devel] [PATCH] watchdog: 6300esb: add exit function

2016-11-29 Thread Richard W.M. Jones
On Mon, Nov 28, 2016 at 05:49:04PM -0800, Li Qiang wrote: > From: Li Qiang > > When the Intel 6300ESB watchdog is hot unplug. The timer allocated > in realize isn't freed thus leaking memory leak. This patch avoid > this through adding the exit function. I will just note that the real hardware i

[Qemu-devel] [PATCH] watchdog: 6300esb: add exit function

2016-11-28 Thread Li Qiang
From: Li Qiang When the Intel 6300ESB watchdog is hot unplug. The timer allocated in realize isn't freed thus leaking memory leak. This patch avoid this through adding the exit function. Signed-off-by: Li Qiang --- hw/watchdog/wdt_i6300esb.c | 9 + 1 file changed, 9 insertions(+) diff