Re: [Qemu-devel] [PATCH] w64: Fix calls of TCG helper functions with 5 arguments

2012-09-14 Thread Blue Swirl
On Wed, Sep 12, 2012 at 7:39 PM, Stefan Weil wrote: > Am 12.09.2012 21:14, schrieb Aurelien Jarno: > >> On Wed, Sep 12, 2012 at 07:12:47PM +0100, Peter Maydell wrote: >>> >>> On 12 September 2012 19:03, Stefan Weil wrote: diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c i

Re: [Qemu-devel] [PATCH] w64: Fix calls of TCG helper functions with 5 arguments

2012-09-12 Thread Stefan Weil
Am 12.09.2012 21:14, schrieb Aurelien Jarno: On Wed, Sep 12, 2012 at 07:12:47PM +0100, Peter Maydell wrote: On 12 September 2012 19:03, Stefan Weil wrote: diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index da17bba..43b5572 100644 --- a/tcg/i386/tcg-target.c +++ b/tcg/i386/tcg-tar

Re: [Qemu-devel] [PATCH] w64: Fix calls of TCG helper functions with 5 arguments

2012-09-12 Thread Stefan Weil
Am 12.09.2012 21:14, schrieb Aurelien Jarno: On Wed, Sep 12, 2012 at 07:12:47PM +0100, Peter Maydell wrote: On 12 September 2012 19:03, Stefan Weil wrote: diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index da17bba..43b5572 100644 --- a/tcg/i386/tcg-target.c +++ b/tcg/i386/tcg-tar

Re: [Qemu-devel] [PATCH] w64: Fix calls of TCG helper functions with 5 arguments

2012-09-12 Thread Aurelien Jarno
On Wed, Sep 12, 2012 at 07:12:47PM +0100, Peter Maydell wrote: > On 12 September 2012 19:03, Stefan Weil wrote: > > diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c > > index da17bba..43b5572 100644 > > --- a/tcg/i386/tcg-target.c > > +++ b/tcg/i386/tcg-target.c > > @@ -118,7 +118,7 @@ s

Re: [Qemu-devel] [PATCH] w64: Fix calls of TCG helper functions with 5 arguments

2012-09-12 Thread Peter Maydell
On 12 September 2012 19:03, Stefan Weil wrote: > diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c > index da17bba..43b5572 100644 > --- a/tcg/i386/tcg-target.c > +++ b/tcg/i386/tcg-target.c > @@ -118,7 +118,7 @@ static void patch_reloc(uint8_t *code_ptr, int type, > static inline int tc

[Qemu-devel] [PATCH] w64: Fix calls of TCG helper functions with 5 arguments

2012-09-12 Thread Stefan Weil
TCG uses 6 registers for function arguments on 64 bit Linux hosts, but only 4 registers on W64 hosts. Commit 2999a0b20074a7e4a58f56572bb1436749368f59 increased the number of arguments for some important helper functions from 4 to 5 which triggered a bug for W64 hosts: QEMU aborts when executing he