Re: [Qemu-devel] [PATCH] vnc: wrap vnc initialization code with CONFIG_VNC

2016-06-16 Thread Eduardo Habkost
On Thu, Jun 16, 2016 at 09:59:10AM +0800, Chao Peng wrote: > commit f8c75b2486 (vnc: Initialization stubs) removed CONFIG_VNC in vl.c > code. However qemu_find_opts("vnc") is NULL when vnc is configured out. > Crash will happen in qemu_opts_foreach() before stub vnc_init_func() is > called. This pa

[Qemu-devel] [PATCH] vnc: wrap vnc initialization code with CONFIG_VNC

2016-06-15 Thread Chao Peng
commit f8c75b2486 (vnc: Initialization stubs) removed CONFIG_VNC in vl.c code. However qemu_find_opts("vnc") is NULL when vnc is configured out. Crash will happen in qemu_opts_foreach() before stub vnc_init_func() is called. This patch add it back. Cc: Eduardo Habkost Signed-off-by: Chao Peng --