On Mo, 2017-01-09 at 17:14 +0100, Pierre Ossman wrote:
> Piggy-backing on the modifier state array made it difficult to send
> out updates at the proper times.
>
> Signed-off-by: Pierre Ossman
Added to ui queue.
thanks,
Gerd
On 04/01/17 09:57, Gerd Hoffmann wrote:
/me wonders how you've tested the patch ...
That would be not at all. Or rather, just a compile. :)
Tried, but checkpatch found some more issues:
Fixed. New patch incoming.
Regards
--
Pierre Ossman Software Development
Cendio AB
Piggy-backing on the modifier state array made it difficult to send
out updates at the proper times.
Signed-off-by: Pierre Ossman
---
ui/vnc.c | 59 ---
ui/vnc.h | 3 ++-
2 files changed, 18 insertions(+), 44 deletions(-)
diff --git a/ui/
On Fr, 2016-12-16 at 10:00 +0100, Pierre Ossman wrote:
> On 15/12/16 17:41, Gerd Hoffmann wrote:
> >>
> >> -caps = ledstate & QEMU_CAPS_LOCK_LED ? 1 : 0;
> >> -num = ledstate & QEMU_NUM_LOCK_LED ? 1 : 0;
> >> -scr = ledstate & QEMU_SCROLL_LOCK_LED ? 1 : 0;
> >> +if (ledstate != v
On 15/12/16 17:41, Gerd Hoffmann wrote:
-caps = ledstate & QEMU_CAPS_LOCK_LED ? 1 : 0;
-num = ledstate & QEMU_NUM_LOCK_LED ? 1 : 0;
-scr = ledstate & QEMU_SCROLL_LOCK_LED ? 1 : 0;
+if (ledstate != vd->ledstate)
+return;
Hmm? Shouldn't that be (ledstate == vd->ledsta
On Do, 2016-12-15 at 14:16 +0100, Pierre Ossman wrote:
> Piggy-backing on the modifier state array made it difficult to send
> out updates at the proper times. So keep track of the LED state in
> a separate variable.
>
> This also moves the handling up a layer in to the VNC Display object
> since
Piggy-backing on the modifier state array made it difficult to send
out updates at the proper times. So keep track of the LED state in
a separate variable.
This also moves the handling up a layer in to the VNC Display object
since the state is global, and also makes sure the state is readily
avail
