Re: [Qemu-devel] [PATCH] vnc: fix segfault in closed connection handling

2018-02-14 Thread Daniel P . Berrangé
On Wed, Feb 07, 2018 at 12:48:44PM +0300, Klim Kireev wrote: > On one of our client's node, due to trying to read from closed ioc, > a segmentation fault occured. Corresponding backtrace: > > 0 object_get_class (obj=obj@entry=0x0) > 1 qio_channel_readv_full (ioc=0x0, iov=0x7ffe55277180 ... > 2

[Qemu-devel] [PATCH] vnc: fix segfault in closed connection handling

2018-02-07 Thread Klim Kireev
On one of our client's node, due to trying to read from closed ioc, a segmentation fault occured. Corresponding backtrace: 0 object_get_class (obj=obj@entry=0x0) 1 qio_channel_readv_full (ioc=0x0, iov=0x7ffe55277180 ... 2 qio_channel_read (ioc= ... 3 vnc_client_read_buf (vs=vs@entry=0x55625f3c

Re: [Qemu-devel] [PATCH] vnc: fix segfault in closed connection handling

2018-01-31 Thread klim
On 01/31/2018 04:16 PM, Marc-André Lureau wrote: Hi On Wed, Jan 31, 2018 at 2:06 PM, Klim Kireev wrote: On one of our client's node, due to trying to read from closed ioc, a segmentation fault occured. Corresponding backtrace: Oops, you probably forgot an extra space before the # interpreted

Re: [Qemu-devel] [PATCH] vnc: fix segfault in closed connection handling

2018-01-31 Thread Marc-André Lureau
Hi On Wed, Jan 31, 2018 at 2:06 PM, Klim Kireev wrote: > On one of our client's node, due to trying to read from closed ioc, > a segmentation fault occured. Corresponding backtrace: > Oops, you probably forgot an extra space before the # interpreted as comment. Do you have a reproducer? > Havi

[Qemu-devel] [PATCH] vnc: fix segfault in closed connection handling

2018-01-31 Thread Klim Kireev
On one of our client's node, due to trying to read from closed ioc, a segmentation fault occured. Corresponding backtrace: Having analyzed the coredump, I understood that the reason is that ioc_tag is reset on vnc_disconnect_start and ioc is cleaned in vnc_disconnect_finish. Between these two even