Re: [Qemu-devel] [PATCH] vnc: fix incorrect checking condition when updating client

2016-07-08 Thread Daniel P. Berrange
On Fri, Jul 08, 2016 at 11:37:36AM +0800, Gonglei wrote: > vs->disconnecting is set to TRUE and vs->ioc is closed, but > vs->ioc isn't set to NULL, so that the vnc_disconnect_finish() > isn't invoked when you update client in vnc_update_client() > after vnc_disconnect_start invoked. Let's using cha

[Qemu-devel] [PATCH] vnc: fix incorrect checking condition when updating client

2016-07-07 Thread Gonglei
vs->disconnecting is set to TRUE and vs->ioc is closed, but vs->ioc isn't set to NULL, so that the vnc_disconnect_finish() isn't invoked when you update client in vnc_update_client() after vnc_disconnect_start invoked. Let's using change the checking condition to avoid resource leak. Signed-off-by