Re: [Qemu-devel] [PATCH] vnc: call sasl_server_init() only when required

2018-08-28 Thread Gerd Hoffmann
On Tue, Aug 28, 2018 at 12:57:56PM +0200, Marc-André Lureau wrote: > ping patchew flagged a codestyle issue, I've expected to see a v2 with that fixed ... cheers, Gerd

Re: [Qemu-devel] [PATCH] vnc: call sasl_server_init() only when required

2018-08-28 Thread Daniel P . Berrangé
On Fri, Aug 17, 2018 at 07:31:03PM +0200, Marc-André Lureau wrote: > VNC server is calling sasl_server_init() during startup of QEMU, even > if SASL auth has not been enabled. > > This may create undesirable warnings like "Could not find keytab file: > /etc/qemu/krb5.tab" when the user didn't conf

Re: [Qemu-devel] [PATCH] vnc: call sasl_server_init() only when required

2018-08-28 Thread Marc-André Lureau
ping On Fri, Aug 17, 2018 at 7:32 PM Marc-André Lureau wrote: > > VNC server is calling sasl_server_init() during startup of QEMU, even > if SASL auth has not been enabled. > > This may create undesirable warnings like "Could not find keytab file: > /etc/qemu/krb5.tab" when the user didn't configu

Re: [Qemu-devel] [PATCH] vnc: call sasl_server_init() only when required

2018-08-18 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180817173104.14691-1-marcandre.lur...@redhat.com Subject: [Qemu-devel] [PATCH] vnc: call sasl_server_init() only when required === TEST SCRIPT BEGIN === #!/bin/bash BASE

[Qemu-devel] [PATCH] vnc: call sasl_server_init() only when required

2018-08-17 Thread Marc-André Lureau
VNC server is calling sasl_server_init() during startup of QEMU, even if SASL auth has not been enabled. This may create undesirable warnings like "Could not find keytab file: /etc/qemu/krb5.tab" when the user didn't configure SASL on host and started VNC server. Instead, only initialize SASL whe