Re: [Qemu-devel] [PATCH] vnc: Fix compilation with --enable-vnc-png

2011-06-27 Thread Anthony Liguori
On 06/27/2011 12:44 AM, Stefan Weil wrote: Am 27.06.2011 07:29, schrieb Stefan Weil: Commit f26e428da505709ec03b2ed2c9eb3db82b30bd7b fixed compilation with --enable-vnc-png, but broke it with --enable-vnc-png. should be with --enable-vnc-jpeg, but broke it with --enable-vnc-png. Please fix t

Re: [Qemu-devel] [PATCH] vnc: Fix compilation with --enable-vnc-png

2011-06-27 Thread Markus Armbruster
Stefan Weil writes: > Commit f26e428da505709ec03b2ed2c9eb3db82b30bd7b fixed compilation > with --enable-vnc-png, but broke it with --enable-vnc-png. You mean "with --enable-vnc-jpeg, but", don't you? > The breakage is caused by pngconfig.h which checks whether > setjmp.h was already included an

Re: [Qemu-devel] [PATCH] vnc: Fix compilation with --enable-vnc-png

2011-06-26 Thread Jan Kiszka
On 2011-06-27 08:10, Stefan Hajnoczi wrote: > On Mon, Jun 27, 2011 at 6:29 AM, Stefan Weil wrote: >> Commit f26e428da505709ec03b2ed2c9eb3db82b30bd7b fixed compilation >> with --enable-vnc-png, but broke it with --enable-vnc-png. >> >> The breakage is caused by pngconfig.h which checks whether >> s

Re: [Qemu-devel] [PATCH] vnc: Fix compilation with --enable-vnc-png

2011-06-26 Thread Stefan Hajnoczi
On Mon, Jun 27, 2011 at 6:29 AM, Stefan Weil wrote: > Commit f26e428da505709ec03b2ed2c9eb3db82b30bd7b fixed compilation > with --enable-vnc-png, but broke it with --enable-vnc-png. > > The breakage is caused by pngconfig.h which checks whether > setjmp.h was already included and fails because qemu

Re: [Qemu-devel] [PATCH] vnc: Fix compilation with --enable-vnc-png

2011-06-26 Thread Jan Kiszka
On 2011-06-27 07:29, Stefan Weil wrote: > Commit f26e428da505709ec03b2ed2c9eb3db82b30bd7b fixed compilation > with --enable-vnc-png, but broke it with --enable-vnc-png. > > The breakage is caused by pngconfig.h which checks whether > setjmp.h was already included and fails because qemu-common.h >

Re: [Qemu-devel] [PATCH] vnc: Fix compilation with --enable-vnc-png

2011-06-26 Thread Stefan Weil
Am 27.06.2011 07:29, schrieb Stefan Weil: Commit f26e428da505709ec03b2ed2c9eb3db82b30bd7b fixed compilation with --enable-vnc-png, but broke it with --enable-vnc-png. should be with --enable-vnc-jpeg, but broke it with --enable-vnc-png. Please fix this detail before applying the patch. Thank

[Qemu-devel] [PATCH] vnc: Fix compilation with --enable-vnc-png

2011-06-26 Thread Stefan Weil
Commit f26e428da505709ec03b2ed2c9eb3db82b30bd7b fixed compilation with --enable-vnc-png, but broke it with --enable-vnc-png. The breakage is caused by pngconfig.h which checks whether setjmp.h was already included and fails because qemu-common.h includes setjmp.h. The check is disabled by definin