Re: [Qemu-devel] [PATCH] vnc: Clean up vncws_send_handshake_response()

2013-01-25 Thread Markus Armbruster
Tim Hardeck writes: > Hi Markus, > > thanks for your input. > > On Wed, 2013-01-23 at 18:16 +0100, Markus Armbruster wrote: >> Use appropriate types, drop superfluous casts, use sizeof, don't >> exploit that this particular call of gnutls_fingerprint() doesn't >> change its last argument. > > you

Re: [Qemu-devel] [PATCH] vnc: Clean up vncws_send_handshake_response()

2013-01-25 Thread Tim Hardeck
Hi Markus, thanks for your input. On Wed, 2013-01-23 at 18:16 +0100, Markus Armbruster wrote: > Use appropriate types, drop superfluous casts, use sizeof, don't > exploit that this particular call of gnutls_fingerprint() doesn't > change its last argument. your patch does work fine but if we exp

Re: [Qemu-devel] [PATCH] vnc: Clean up vncws_send_handshake_response()

2013-01-24 Thread Tim Hardeck
Hi Markus, On 01/23/2013 06:16 PM, Markus Armbruster wrote: > Use appropriate types, drop superfluous casts, use sizeof, don't > exploit that this particular call of gnutls_fingerprint() doesn't > change its last argument. > > Signed-off-by: Markus Armbruster Reviewed-by: Tim Hardeck Regards

[Qemu-devel] [PATCH] vnc: Clean up vncws_send_handshake_response()

2013-01-23 Thread Markus Armbruster
Use appropriate types, drop superfluous casts, use sizeof, don't exploit that this particular call of gnutls_fingerprint() doesn't change its last argument. Signed-off-by: Markus Armbruster --- ui/vnc-ws.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ui/vnc-ws.c b/ui