Re: [Qemu-devel] [PATCH] vnc: Add break statement

2012-02-25 Thread Andreas Färber
Am 25.02.2012 17:09, schrieb Stefan Weil: > Am 25.02.2012 16:57, schrieb Andreas Färber: >> Am 25.02.2012 14:57, schrieb Stefan Weil: >>> This was not a bug, but it is not common practice to omit the break >>> statement >>> from the last case statement before an empty default case. >>> >>> Any chan

Re: [Qemu-devel] [PATCH] vnc: Add break statement

2012-02-25 Thread Stefan Weil
Am 25.02.2012 16:57, schrieb Andreas Färber: Am 25.02.2012 14:57, schrieb Stefan Weil: This was not a bug, but it is not common practice to omit the break statement from the last case statement before an empty default case. Any change of the default case would introduce a bug. This was report

Re: [Qemu-devel] [PATCH] vnc: Add break statement

2012-02-25 Thread Andreas Färber
Am 25.02.2012 14:57, schrieb Stefan Weil: > This was not a bug, but it is not common practice to omit the break statement > from the last case statement before an empty default case. > > Any change of the default case would introduce a bug. > > This was reported as a warning by splint. > > Signe

Re: [Qemu-devel] [PATCH] vnc: Add break statement

2012-02-25 Thread Stefan Weil
Am 25.02.2012 15:18, schrieb Eric Blake: On 02/25/2012 06:57 AM, Stefan Weil wrote: This was not a bug, but it is not common practice to omit the break statement from the last case statement before an empty default case. Any change of the default case would introduce a bug. This was reported a

Re: [Qemu-devel] [PATCH] vnc: Add break statement

2012-02-25 Thread Eric Blake
On 02/25/2012 06:57 AM, Stefan Weil wrote: > This was not a bug, but it is not common practice to omit the break statement > from the last case statement before an empty default case. > > Any change of the default case would introduce a bug. > > This was reported as a warning by splint. > > Sign

[Qemu-devel] [PATCH] vnc: Add break statement

2012-02-25 Thread Stefan Weil
This was not a bug, but it is not common practice to omit the break statement from the last case statement before an empty default case. Any change of the default case would introduce a bug. This was reported as a warning by splint. Signed-off-by: Stefan Weil --- ui/vnc-enc-hextile-template.h