Re: [Qemu-devel] [PATCH] vmxnet3: Do not fill stats if device is inactive

2015-10-20 Thread Dmitry Fleytman
Hi Jason, Sure. No problem. Acked-by: Dmitry Fleytman mailto:dmi...@daynix.com>> Dmitry. > On 20 Oct 2015, at 06:08 AM, Jason Wang wrote: > > > > On 10/18/2015 03:16 PM, Dmitry Fleytman wrote: >> ACK > > Hi Dmitry: > > Thanks a lot for the reviewing. > > As I want to add your "Acked-by"

Re: [Qemu-devel] [PATCH] vmxnet3: Do not fill stats if device is inactive

2015-10-20 Thread Jason Wang
On 10/20/2015 03:11 PM, Dmitry Fleytman wrote: > Hi Jason, > > Sure. No problem. > > Acked-by: Dmitry Fleytman mailto:dmi...@daynix.com>> > > Dmitry. Thanks. > >> On 20 Oct 2015, at 06:08 AM, Jason Wang > > wrote: >> >> >> >> On 10/18/2015 03:16 PM, Dmitry Fleytman w

Re: [Qemu-devel] [PATCH] vmxnet3: Do not fill stats if device is inactive

2015-10-19 Thread Jason Wang
On 10/15/2015 06:54 PM, Dana Rubin wrote: > From: Shmulik Ladkani > > Guest OS may issue VMXNET3_CMD_GET_STATS even before device was > activated (for example in linux, after insmod but prior net-dev open). > > Accessing shared descriptors prior device activation is illegal as the > VMXNET3State

Re: [Qemu-devel] [PATCH] vmxnet3: Do not fill stats if device is inactive

2015-10-19 Thread Jason Wang
On 10/18/2015 03:16 PM, Dmitry Fleytman wrote: > ACK Hi Dmitry: Thanks a lot for the reviewing. As I want to add your "Acked-by" in the patch, could you pls add a formal one in the future? (Which can make my life a little bit easier). >> On 15 Oct 2015, at 13:54 PM, Dana Rubin >> wrote: >>

Re: [Qemu-devel] [PATCH] vmxnet3: Do not fill stats if device is inactive

2015-10-18 Thread Dmitry Fleytman
ACK > On 15 Oct 2015, at 13:54 PM, Dana Rubin > wrote: > > From: Shmulik Ladkani > > Guest OS may issue VMXNET3_CMD_GET_STATS even before device was > activated (for example in linux, after insmod but prior net-dev open). > > Accessing shared descriptors prior device activation is illegal as

[Qemu-devel] [PATCH] vmxnet3: Do not fill stats if device is inactive

2015-10-15 Thread Dana Rubin
From: Shmulik Ladkani Guest OS may issue VMXNET3_CMD_GET_STATS even before device was activated (for example in linux, after insmod but prior net-dev open). Accessing shared descriptors prior device activation is illegal as the VMXNET3State structures have not been fully initialized. As a resul