Re: [Qemu-devel] [PATCH] vmware_vga: fix out of bounds and invalid rects updating

2013-01-25 Thread Michael Tokarev
25.01.2013 21:08, Anthony Liguori wrote: > Michael Tokarev writes: > >> 25.01.2013 18:15, Anthony Liguori wrote: >>> WARNING: __func__ should be used instead of gcc specific __FUNCTION__ >>> #73: FILE: hw/vmware_vga.c:300: >>> +fprintf(stderr, "%s: update x was < 0 (%d)\n", __FUNCTION__,

Re: [Qemu-devel] [PATCH] vmware_vga: fix out of bounds and invalid rects updating

2013-01-25 Thread Anthony Liguori
Michael Tokarev writes: > 25.01.2013 18:15, Anthony Liguori wrote: >> Hi, >> >> Thank you for submitting your patch series. checkpatch.pl has >> detected that one or more of the patches in this series violate >> the QEMU coding style. >> >> If you believe this message was sent in error, please

Re: [Qemu-devel] [PATCH] vmware_vga: fix out of bounds and invalid rects updating

2013-01-25 Thread Anthony Liguori
Hi, Thank you for submitting your patch series. checkpatch.pl has detected that one or more of the patches in this series violate the QEMU coding style. If you believe this message was sent in error, please ignore it or respond here with an explanation. Otherwise, please correct the coding styl

Re: [Qemu-devel] [PATCH] vmware_vga: fix out of bounds and invalid rects updating

2013-01-25 Thread Michael Tokarev
25.01.2013 18:15, Anthony Liguori wrote: > Hi, > > Thank you for submitting your patch series. checkpatch.pl has > detected that one or more of the patches in this series violate > the QEMU coding style. > > If you believe this message was sent in error, please ignore it > or respond here with a

Re: [Qemu-devel] [PATCH] vmware_vga: fix out of bounds and invalid rects updating

2013-01-24 Thread Serge Hallyn
Quoting Michael Tokarev (m...@tls.msk.ru): > This is a follow up for several attempts to fix this issue. > > Previous incarnations: > > 1. http://thread.gmane.org/gmane.linux.ubuntu.bugs.general/3156089 > https://bugs.launchpad.net/bugs/918791 > "qemu-kvm dies when using vmvga driver and unity in

Re: [Qemu-devel] [PATCH] vmware_vga: fix out of bounds and invalid rects updating

2013-01-24 Thread Marek Vasut
Dear Michael Tokarev, > This is a follow up for several attempts to fix this issue. > > Previous incarnations: > > 1. http://thread.gmane.org/gmane.linux.ubuntu.bugs.general/3156089 > https://bugs.launchpad.net/bugs/918791 > "qemu-kvm dies when using vmvga driver and unity in the guest" bug. > F

[Qemu-devel] [PATCH] vmware_vga: fix out of bounds and invalid rects updating

2013-01-24 Thread Michael Tokarev
This is a follow up for several attempts to fix this issue. Previous incarnations: 1. http://thread.gmane.org/gmane.linux.ubuntu.bugs.general/3156089 https://bugs.launchpad.net/bugs/918791 "qemu-kvm dies when using vmvga driver and unity in the guest" bug. Fix by Serge Hallyn: https://launchpadl