Re: [Qemu-devel] [PATCH] vmdk: Allow selecting SCSI adapter in image creation

2013-01-29 Thread Paolo Bonzini
Il 29/01/2013 00:18, Othmar Pasteka ha scritto: > right after sending the patch I discovered this indentation bug. > I check with checkpatch before sending it, but it didn't complain > and it slipped on my side. Should I resend the patch with that fixed? Yes, please do. Paolo

Re: [Qemu-devel] [PATCH] vmdk: Allow selecting SCSI adapter in image creation

2013-01-28 Thread Othmar Pasteka
Hello, On Mon, Jan 28, 2013 at 11:56:47PM +0100, Othmar Pasteka wrote: > @@ -1453,6 +1454,7 @@ static int vmdk_create(const char *filename, > QEMUOptionParameter *options) > const char *desc_extent_line; > char parent_desc_line[BUF_SIZE] = ""; > uint32_t parent_cid = 0x; >

[Qemu-devel] [PATCH] vmdk: Allow selecting SCSI adapter in image creation

2013-01-28 Thread Othmar Pasteka
Introduce a new option "adapter_type" when converting to vmdk images. It can be one of the following: ide (default), buslogic, lsilogic or legacyESX (according to the vmdk spec from vmware). In case of a non-ide adapter, heads is set to 255 instead of the 16. The latter is used for "ide". Also se