Re: [Qemu-devel] [PATCH] vl.c: remove init_clocks call from main

2014-05-07 Thread Stefan Hajnoczi
On Tue, May 06, 2014 at 04:59:53PM +0400, Kirill Batuzov wrote: > Clocks are initialized in qemu_init_main_loop. They are not needed before it. > Initializing them twice is not only unnecessary but is harmful: it results in > memory leak and potentially can lead to a situation where different parts

Re: [Qemu-devel] [PATCH] vl.c: remove init_clocks call from main

2014-05-06 Thread Alex Bligh
On 6 May 2014, at 17:01, Peter Maydell wrote: >> >> So if I read this right, init_clocks() is now only done in vl.c. > > No, you're misreading it -- the commit message says "remove > init_clocks call from main" and you can see from the diffstat > it's removed from vl.c. It's now done only in qe

Re: [Qemu-devel] [PATCH] vl.c: remove init_clocks call from main

2014-05-06 Thread Peter Maydell
On 6 May 2014 16:57, Alex Bligh wrote: > > On 6 May 2014, at 13:59, Kirill Batuzov wrote: > >> Clocks are initialized in qemu_init_main_loop. They are not needed before it. >> Initializing them twice is not only unnecessary but is harmful: it results in >> memory leak and potentially can lead to a

Re: [Qemu-devel] [PATCH] vl.c: remove init_clocks call from main

2014-05-06 Thread Alex Bligh
On 6 May 2014, at 13:59, Kirill Batuzov wrote: > Clocks are initialized in qemu_init_main_loop. They are not needed before it. > Initializing them twice is not only unnecessary but is harmful: it results in > memory leak and potentially can lead to a situation where different parts of > QEMU use

[Qemu-devel] [PATCH] vl.c: remove init_clocks call from main

2014-05-06 Thread Kirill Batuzov
Clocks are initialized in qemu_init_main_loop. They are not needed before it. Initializing them twice is not only unnecessary but is harmful: it results in memory leak and potentially can lead to a situation where different parts of QEMU use different sets of timers. To avoid it remove init_clocks