Re: [Qemu-devel] [PATCH] vl.c: remove duplicate call to qemu_get_machine_opts

2016-02-08 Thread Marcel Apfelbaum
On 02/08/2016 09:23 PM, Laszlo Ersek wrote: On 02/08/16 19:59, Marcel Apfelbaum wrote: On 02/08/2016 06:47 PM, Laszlo Ersek wrote: On 02/08/16 13:27, Marcel Apfelbaum wrote: On 02/08/2016 02:22 PM, Laszlo Ersek wrote: On 02/08/16 12:45, Marcel Apfelbaum wrote: Also we can use current machine

Re: [Qemu-devel] [PATCH] vl.c: remove duplicate call to qemu_get_machine_opts

2016-02-08 Thread Laszlo Ersek
On 02/08/16 19:59, Marcel Apfelbaum wrote: > On 02/08/2016 06:47 PM, Laszlo Ersek wrote: >> On 02/08/16 13:27, Marcel Apfelbaum wrote: >>> On 02/08/2016 02:22 PM, Laszlo Ersek wrote: On 02/08/16 12:45, Marcel Apfelbaum wrote: > Also we can use current machine properties instead of querying

Re: [Qemu-devel] [PATCH] vl.c: remove duplicate call to qemu_get_machine_opts

2016-02-08 Thread Marcel Apfelbaum
On 02/08/2016 06:47 PM, Laszlo Ersek wrote: On 02/08/16 13:27, Marcel Apfelbaum wrote: On 02/08/2016 02:22 PM, Laszlo Ersek wrote: On 02/08/16 12:45, Marcel Apfelbaum wrote: Also we can use current machine properties instead of querying machine's opts. Why? :) For me at least, you'll have to

Re: [Qemu-devel] [PATCH] vl.c: remove duplicate call to qemu_get_machine_opts

2016-02-08 Thread Laszlo Ersek
On 02/08/16 13:27, Marcel Apfelbaum wrote: > On 02/08/2016 02:22 PM, Laszlo Ersek wrote: >> On 02/08/16 12:45, Marcel Apfelbaum wrote: >>> Also we can use current machine properties instead of querying >>> machine's opts. >> >> Why? :) For me at least, you'll have to spell it out. > > The theory w

Re: [Qemu-devel] [PATCH] vl.c: remove duplicate call to qemu_get_machine_opts

2016-02-08 Thread Marcel Apfelbaum
On 02/08/2016 02:22 PM, Laszlo Ersek wrote: On 02/08/16 12:45, Marcel Apfelbaum wrote: Also we can use current machine properties instead of querying machine's opts. Why? :) For me at least, you'll have to spell it out. The theory would be that is cleaner to call an object property than use

Re: [Qemu-devel] [PATCH] vl.c: remove duplicate call to qemu_get_machine_opts

2016-02-08 Thread Laszlo Ersek
On 02/08/16 12:45, Marcel Apfelbaum wrote: > Also we can use current machine properties instead of querying machine's opts. Why? :) For me at least, you'll have to spell it out. Thanks Laszlo > > Signed-off-by: Marcel Apfelbaum > --- > vl.c | 9 - > 1 file changed, 4 insertions(+), 5

[Qemu-devel] [PATCH] vl.c: remove duplicate call to qemu_get_machine_opts

2016-02-08 Thread Marcel Apfelbaum
Also we can use current machine properties instead of querying machine's opts. Signed-off-by: Marcel Apfelbaum --- vl.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/vl.c b/vl.c index 5873248..c03a4fe 100644 --- a/vl.c +++ b/vl.c @@ -4353,11 +4353,10 @@ int main(in