Re: [Qemu-devel] [PATCH] vl.c: Don't print errno after failed qemu_chr_new()

2012-07-28 Thread Blue Swirl
On Sat, Jul 21, 2012 at 9:07 AM, Peter Maydell wrote: > Ping? > > patchwork url: http://patchwork.ozlabs.org/patch/169860/ Thanks, applied. > > -- PMM > > On 9 July 2012 15:28, Peter Maydell wrote: >> The qemu_chr_new() function doesn't set errno on failure, so >> don't print strerror(errno) on

Re: [Qemu-devel] [PATCH] vl.c: Don't print errno after failed qemu_chr_new()

2012-07-21 Thread Peter Maydell
Ping? patchwork url: http://patchwork.ozlabs.org/patch/169860/ -- PMM On 9 July 2012 15:28, Peter Maydell wrote: > The qemu_chr_new() function doesn't set errno on failure, so > don't print strerror(errno) on the error handling path when > dealing with the -serial, -parallel and -virtioconsole

[Qemu-devel] [PATCH] vl.c: Don't print errno after failed qemu_chr_new()

2012-07-09 Thread Peter Maydell
The qemu_chr_new() function doesn't set errno on failure, so don't print strerror(errno) on the error handling path when dealing with the -serial, -parallel and -virtioconsole arguments. This avoids nonsensical error messages like: $ ./arm-softmmu/qemu-system-arm -serial wombat qemu: could not