Re: [Qemu-devel] [PATCH] virtio dataplane: adapt dataplane for virtio Version 1

2015-09-03 Thread Cornelia Huck
On Thu, 3 Sep 2015 18:08:42 +0100 Stefan Hajnoczi wrote: > On Wed, Aug 26, 2015 at 02:55:45PM +0200, Cornelia Huck wrote: > > On Wed, 26 Aug 2015 13:50:52 +0100 > > Stefan Hajnoczi wrote: > > > > > On Tue, Aug 25, 2015 at 12:33:30PM +0200, Pierre Morel wrote: > > > > -vring_init(&vring->vr,

Re: [Qemu-devel] [PATCH] virtio dataplane: adapt dataplane for virtio Version 1

2015-09-03 Thread Stefan Hajnoczi
On Wed, Aug 26, 2015 at 02:55:45PM +0200, Cornelia Huck wrote: > On Wed, 26 Aug 2015 13:50:52 +0100 > Stefan Hajnoczi wrote: > > > On Tue, Aug 25, 2015 at 12:33:30PM +0200, Pierre Morel wrote: > > > -vring_init(&vring->vr, virtio_queue_get_num(vdev, n), vring_ptr, > > > 4096); > > > > vring

Re: [Qemu-devel] [PATCH] virtio dataplane: adapt dataplane for virtio Version 1

2015-08-26 Thread Cornelia Huck
On Wed, 26 Aug 2015 13:50:52 +0100 Stefan Hajnoczi wrote: > On Tue, Aug 25, 2015 at 12:33:30PM +0200, Pierre Morel wrote: > > -vring_init(&vring->vr, virtio_queue_get_num(vdev, n), vring_ptr, 4096); > > vring_init() is no longer used. Please delete it. > vring_init() is defined in a heade

Re: [Qemu-devel] [PATCH] virtio dataplane: adapt dataplane for virtio Version 1

2015-08-26 Thread Stefan Hajnoczi
On Tue, Aug 25, 2015 at 12:33:30PM +0200, Pierre Morel wrote: > -vring_init(&vring->vr, virtio_queue_get_num(vdev, n), vring_ptr, 4096); vring_init() is no longer used. Please delete it.

Re: [Qemu-devel] [PATCH] virtio dataplane: adapt dataplane for virtio Version 1

2015-08-26 Thread Pierre Morel
On 08/26/2015 01:29 PM, Greg Kurz wrote: On Tue, 25 Aug 2015 12:33:30 +0200 Pierre Morel wrote: Let dataplane allocate different region for the desc/avail/used ring regions. Signed-off-by: Pierre Morel --- Great ! It works ! Since we end up with 3 blocks of code that are identical save t

Re: [Qemu-devel] [PATCH] virtio dataplane: adapt dataplane for virtio Version 1

2015-08-26 Thread Greg Kurz
On Tue, 25 Aug 2015 12:33:30 +0200 Pierre Morel wrote: > Let dataplane allocate different region for the desc/avail/used > ring regions. > > Signed-off-by: Pierre Morel > --- Great ! It works ! Since we end up with 3 blocks of code that are identical save the ring region name, we can simplify

[Qemu-devel] [PATCH] virtio dataplane: adapt dataplane for virtio Version 1

2015-08-25 Thread Pierre Morel
Let dataplane allocate different region for the desc/avail/used ring regions. Signed-off-by: Pierre Morel --- hw/virtio/dataplane/vring.c | 54 -- include/hw/virtio/dataplane/vring.h |4 ++- 2 files changed, 47 insertions(+), 11 deletions(-) diff --