Re: [Qemu-devel] [PATCH] virtio-serial: add enable_backend callback

2017-09-19 Thread Paolo Bonzini
On 18/09/2017 11:37, Pavel Butsykin wrote: >>> >> >> To understand the patch better this doesn't fix _all_ stopped states, >> only migration, right? That said it's a valid bugfix even independent >> of the effects for stopped runstate. > Yes, the bug only appears on the migration. Actually, to pro

Re: [Qemu-devel] [PATCH] virtio-serial: add enable_backend callback

2017-09-18 Thread Pavel Butsykin
On 15.09.2017 20:09, Paolo Bonzini wrote: On 07/07/2017 16:21, Pavel Butsykin wrote: We should guarantee that RAM will not be modified while VM has a stopped state, otherwise it can lead to negative consequences during post-copy migration. In RUN_STATE_FINISH_MIGRATE step, it's expected that RAM

Re: [Qemu-devel] [PATCH] virtio-serial: add enable_backend callback

2017-09-15 Thread Paolo Bonzini
On 07/07/2017 16:21, Pavel Butsykin wrote: > We should guarantee that RAM will not be modified while VM has a stopped > state, otherwise it can lead to negative consequences during post-copy > migration. In RUN_STATE_FINISH_MIGRATE step, it's expected that RAM on > source side will not be modified

Re: [Qemu-devel] [PATCH] virtio-serial: add enable_backend callback

2017-09-15 Thread Pavel Butsykin
On 17.07.2017 16:56, Pavel Butsykin wrote: On 07.07.2017 17:21, Pavel Butsykin wrote: We should guarantee that RAM will not be modified while VM has a stopped state, otherwise it can lead to negative consequences during post-copy migration. In RUN_STATE_FINISH_MIGRATE step, it's expected that RA

Re: [Qemu-devel] [PATCH] virtio-serial: add enable_backend callback

2017-08-24 Thread Denis V. Lunev
On 07/07/2017 05:21 PM, Pavel Butsykin wrote: > We should guarantee that RAM will not be modified while VM has a stopped > state, otherwise it can lead to negative consequences during post-copy > migration. In RUN_STATE_FINISH_MIGRATE step, it's expected that RAM on > source side will not be modifi

Re: [Qemu-devel] [PATCH] virtio-serial: add enable_backend callback

2017-07-17 Thread Pavel Butsykin
On 07.07.2017 17:21, Pavel Butsykin wrote: We should guarantee that RAM will not be modified while VM has a stopped state, otherwise it can lead to negative consequences during post-copy migration. In RUN_STATE_FINISH_MIGRATE step, it's expected that RAM on source side will not be modified as thi

Re: [Qemu-devel] [PATCH] virtio-serial: add enable_backend callback

2017-07-11 Thread Laurent Vivier
On 10/07/2017 18:39, Michael S. Tsirkin wrote: > On Mon, Jul 10, 2017 at 04:13:54PM +0200, Laurent Vivier wrote: >>> static void virtconsole_realize(DeviceState *dev, Error **errp) >>> { >>> VirtIOSerialPort *port = VIRTIO_SERIAL_PORT(dev); >>> @@ -233,6 +253,7 @@ static void virtserialport_

Re: [Qemu-devel] [PATCH] virtio-serial: add enable_backend callback

2017-07-10 Thread Pavel Butsykin
On 10.07.2017 17:13, Laurent Vivier wrote: On 07/07/2017 16:21, Pavel Butsykin wrote: We should guarantee that RAM will not be modified while VM has a stopped state, otherwise it can lead to negative consequences during post-copy migration. In RUN_STATE_FINISH_MIGRATE step, it's expected that RA

Re: [Qemu-devel] [PATCH] virtio-serial: add enable_backend callback

2017-07-10 Thread Michael S. Tsirkin
On Mon, Jul 10, 2017 at 04:13:54PM +0200, Laurent Vivier wrote: > > static void virtconsole_realize(DeviceState *dev, Error **errp) > > { > > VirtIOSerialPort *port = VIRTIO_SERIAL_PORT(dev); > > @@ -233,6 +253,7 @@ static void virtserialport_class_init(ObjectClass > > *klass, void *data) >

Re: [Qemu-devel] [PATCH] virtio-serial: add enable_backend callback

2017-07-10 Thread Laurent Vivier
On 07/07/2017 16:21, Pavel Butsykin wrote: > We should guarantee that RAM will not be modified while VM has a stopped > state, otherwise it can lead to negative consequences during post-copy > migration. In RUN_STATE_FINISH_MIGRATE step, it's expected that RAM on > source side will not be modified

[Qemu-devel] [PATCH] virtio-serial: add enable_backend callback

2017-07-07 Thread Pavel Butsykin
We should guarantee that RAM will not be modified while VM has a stopped state, otherwise it can lead to negative consequences during post-copy migration. In RUN_STATE_FINISH_MIGRATE step, it's expected that RAM on source side will not be modified as this could lead to non-consistent vm state on th