Re: [Qemu-devel] [PATCH] virtio-scsi: fix object check failure

2014-07-25 Thread Ming Lei
On Sat, Jul 26, 2014 at 7:10 AM, Nicholas A. Bellinger wrote: > Hi Ming & Paolo, > > On Wed, 2014-06-18 at 23:11 +0800, Ming Lei wrote: >> On Wed, Jun 18, 2014 at 11:06 PM, Paolo Bonzini wrote: >> > Il 18/06/2014 17:02, Paolo Bonzini ha scritto: >> > >> >> Il 18/06/2014 16:18, Ming Lei ha scritto

Re: [Qemu-devel] [PATCH] virtio-scsi: fix object check failure

2014-07-25 Thread Nicholas A. Bellinger
Hi Ming & Paolo, On Wed, 2014-06-18 at 23:11 +0800, Ming Lei wrote: > On Wed, Jun 18, 2014 at 11:06 PM, Paolo Bonzini wrote: > > Il 18/06/2014 17:02, Paolo Bonzini ha scritto: > > > >> Il 18/06/2014 16:18, Ming Lei ha scritto: > > > This should never be triggered by vhost-scsi. Perhaps

Re: [Qemu-devel] [PATCH] virtio-scsi: fix object check failure

2014-06-18 Thread Ming Lei
On Wed, Jun 18, 2014 at 11:06 PM, Paolo Bonzini wrote: > Il 18/06/2014 17:02, Paolo Bonzini ha scritto: > >> Il 18/06/2014 16:18, Ming Lei ha scritto: > This should never be triggered by vhost-scsi. Perhaps a bug in the kernel? >>> >>> It can be triggered with rmmod, system suspend

Re: [Qemu-devel] [PATCH] virtio-scsi: fix object check failure

2014-06-18 Thread Paolo Bonzini
Il 18/06/2014 17:02, Paolo Bonzini ha scritto: Il 18/06/2014 16:18, Ming Lei ha scritto: > This should never be triggered by vhost-scsi. Perhaps a bug in the kernel? It can be triggered with rmmod, system suspend, reboot... Yes, but it should not. What happens if you change VHOST_SCSI_VQ_NU

Re: [Qemu-devel] [PATCH] virtio-scsi: fix object check failure

2014-06-18 Thread Paolo Bonzini
Il 18/06/2014 16:18, Ming Lei ha scritto: > This should never be triggered by vhost-scsi. Perhaps a bug in the kernel? It can be triggered with rmmod, system suspend, reboot... Yes, but it should not. What happens if you change VHOST_SCSI_VQ_NUM_FIXED from 2 to 3? Paolo

Re: [Qemu-devel] [PATCH] virtio-scsi: fix object check failure

2014-06-18 Thread Ming Lei
On Wed, Jun 18, 2014 at 10:23 PM, Andreas Färber wrote: > Am 18.06.2014 14:13, schrieb Ming Lei: >> In case of vhost-scsi, the object type of VirtIODevice isn't >> VirtIOSCSI, so use the cast trick to fix the problem like >> in virtio_scsi_handle_cmd() >> >> Cc: qemu-sta...@nongnu.org >> Cc: Antho

Re: [Qemu-devel] [PATCH] virtio-scsi: fix object check failure

2014-06-18 Thread Andreas Färber
Am 18.06.2014 14:13, schrieb Ming Lei: > In case of vhost-scsi, the object type of VirtIODevice isn't > VirtIOSCSI, so use the cast trick to fix the problem like > in virtio_scsi_handle_cmd() > > Cc: qemu-sta...@nongnu.org > Cc: Anthony Liguori > Cc: "Michael S. Tsirkin" > Cc: Paolo Bonzini > S

Re: [Qemu-devel] [PATCH] virtio-scsi: fix object check failure

2014-06-18 Thread Ming Lei
On Wed, Jun 18, 2014 at 8:29 PM, Paolo Bonzini wrote: > Il 18/06/2014 14:13, Ming Lei ha scritto: > >> In case of vhost-scsi, the object type of VirtIODevice isn't >> VirtIOSCSI, so use the cast trick to fix the problem like >> in virtio_scsi_handle_cmd() >> >> Cc: qemu-sta...@nongnu.org >> Cc: An

Re: [Qemu-devel] [PATCH] virtio-scsi: fix object check failure

2014-06-18 Thread Paolo Bonzini
Il 18/06/2014 14:13, Ming Lei ha scritto: In case of vhost-scsi, the object type of VirtIODevice isn't VirtIOSCSI, so use the cast trick to fix the problem like in virtio_scsi_handle_cmd() Cc: qemu-sta...@nongnu.org Cc: Anthony Liguori Cc: "Michael S. Tsirkin" Cc: Paolo Bonzini Signed-off-by:

[Qemu-devel] [PATCH] virtio-scsi: fix object check failure

2014-06-18 Thread Ming Lei
In case of vhost-scsi, the object type of VirtIODevice isn't VirtIOSCSI, so use the cast trick to fix the problem like in virtio_scsi_handle_cmd() Cc: qemu-sta...@nongnu.org Cc: Anthony Liguori Cc: "Michael S. Tsirkin" Cc: Paolo Bonzini Signed-off-by: Ming Lei --- hw/scsi/virtio-scsi.c |2