Re: [Qemu-devel] [PATCH] virtio-pci: replace byte swap hack

2013-01-09 Thread Michael S. Tsirkin
On Wed, Jan 09, 2013 at 08:39:08PM +, Blue Swirl wrote: > On Mon, Jan 7, 2013 at 4:11 PM, Michael S. Tsirkin wrote: > > On Sun, Jan 06, 2013 at 08:04:39PM +, Blue Swirl wrote: > >> On Sun, Jan 6, 2013 at 6:25 PM, Andreas Färber wrote: > >> > Am 06.01.2013 14:17, schrieb Alexander Graf: >

Re: [Qemu-devel] [PATCH] virtio-pci: replace byte swap hack

2013-01-09 Thread Blue Swirl
On Mon, Jan 7, 2013 at 4:11 PM, Michael S. Tsirkin wrote: > On Sun, Jan 06, 2013 at 08:04:39PM +, Blue Swirl wrote: >> On Sun, Jan 6, 2013 at 6:25 PM, Andreas Färber wrote: >> > Am 06.01.2013 14:17, schrieb Alexander Graf: >> >> >> >> On 30.12.2012, at 13:55, Blue Swirl wrote: >> >> >> >>> Re

Re: [Qemu-devel] [PATCH] virtio-pci: replace byte swap hack

2013-01-07 Thread Michael S. Tsirkin
On Sun, Jan 06, 2013 at 08:04:39PM +, Blue Swirl wrote: > On Sun, Jan 6, 2013 at 6:25 PM, Andreas Färber wrote: > > Am 06.01.2013 14:17, schrieb Alexander Graf: > >> > >> On 30.12.2012, at 13:55, Blue Swirl wrote: > >> > >>> Remove byte swaps by declaring the config space > >>> as native endia

Re: [Qemu-devel] [PATCH] virtio-pci: replace byte swap hack

2013-01-06 Thread Blue Swirl
On Sun, Jan 6, 2013 at 6:25 PM, Andreas Färber wrote: > Am 06.01.2013 14:17, schrieb Alexander Graf: >> >> On 30.12.2012, at 13:55, Blue Swirl wrote: >> >>> Remove byte swaps by declaring the config space >>> as native endian. >> >> This is wrong. Virtio-pci config space is split into 2 regions. O

Re: [Qemu-devel] [PATCH] virtio-pci: replace byte swap hack

2013-01-06 Thread Alexander Graf
Am 06.01.2013 um 19:26 schrieb Blue Swirl : > On Sun, Jan 6, 2013 at 1:17 PM, Alexander Graf wrote: >> >> On 30.12.2012, at 13:55, Blue Swirl wrote: >> >>> Remove byte swaps by declaring the config space >>> as native endian. >> >> This is wrong. Virtio-pci config space is split into 2 regio

Re: [Qemu-devel] [PATCH] virtio-pci: replace byte swap hack

2013-01-06 Thread Blue Swirl
On Sun, Jan 6, 2013 at 1:17 PM, Alexander Graf wrote: > > On 30.12.2012, at 13:55, Blue Swirl wrote: > >> Remove byte swaps by declaring the config space >> as native endian. > > This is wrong. Virtio-pci config space is split into 2 regions. One with > native endianness, the other one with littl

Re: [Qemu-devel] [PATCH] virtio-pci: replace byte swap hack

2013-01-06 Thread Andreas Färber
Am 06.01.2013 14:17, schrieb Alexander Graf: > > On 30.12.2012, at 13:55, Blue Swirl wrote: > >> Remove byte swaps by declaring the config space >> as native endian. > > This is wrong. Virtio-pci config space is split into 2 regions. One with > native endianness, the other one with little endia

Re: [Qemu-devel] [PATCH] virtio-pci: replace byte swap hack

2013-01-06 Thread Alexander Graf
On 30.12.2012, at 13:55, Blue Swirl wrote: > Remove byte swaps by declaring the config space > as native endian. This is wrong. Virtio-pci config space is split into 2 regions. One with native endianness, the other one with little endian. Alex > > Signed-off-by: Blue Swirl > --- > exec.c

[Qemu-devel] [PATCH] virtio-pci: replace byte swap hack

2012-12-30 Thread Blue Swirl
Remove byte swaps by declaring the config space as native endian. Signed-off-by: Blue Swirl --- exec.c | 18 -- hw/virtio-pci.c | 17 + 2 files changed, 1 insertions(+), 34 deletions(-) diff --git a/exec.c b/exec.c index a6923ad..140eb56 100644 --- a