Re: [Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-10-13 Thread Greg Kurz
On Mon, 13 Oct 2014 14:09:54 +0300 "Michael S. Tsirkin" wrote: > On Mon, Oct 13, 2014 at 10:49:41AM +0200, Greg Kurz wrote: > > On Mon, 6 Oct 2014 20:25:04 +0300 > > "Michael S. Tsirkin" wrote: > > > [...] > > > > > > BTW I reverted that patch, and to fix migration, I'm thinking > > > about app

Re: [Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-10-13 Thread Michael S. Tsirkin
On Mon, Oct 13, 2014 at 02:29:20PM +0200, Alexander Graf wrote: > > > On 13.10.14 12:42, Greg Kurz wrote: > > On Mon, 13 Oct 2014 12:01:07 +0300 > > "Michael S. Tsirkin" wrote: > > > >> On Mon, Oct 13, 2014 at 10:49:41AM +0200, Greg Kurz wrote: > >>> On Mon, 6 Oct 2014 20:25:04 +0300 > >>> "Mic

Re: [Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-10-13 Thread Alexander Graf
On 13.10.14 12:42, Greg Kurz wrote: > On Mon, 13 Oct 2014 12:01:07 +0300 > "Michael S. Tsirkin" wrote: > >> On Mon, Oct 13, 2014 at 10:49:41AM +0200, Greg Kurz wrote: >>> On Mon, 6 Oct 2014 20:25:04 +0300 >>> "Michael S. Tsirkin" wrote: [...] BTW I reverted that patch, and to fi

Re: [Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-10-13 Thread Michael S. Tsirkin
On Mon, Oct 13, 2014 at 10:49:41AM +0200, Greg Kurz wrote: > On Mon, 6 Oct 2014 20:25:04 +0300 > "Michael S. Tsirkin" wrote: > > [...] > > > > BTW I reverted that patch, and to fix migration, I'm thinking > > about applying the following patch on top of master. > > > > Michael, > > I could for

Re: [Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-10-13 Thread Greg Kurz
On Mon, 13 Oct 2014 12:01:07 +0300 "Michael S. Tsirkin" wrote: > On Mon, Oct 13, 2014 at 10:49:41AM +0200, Greg Kurz wrote: > > On Mon, 6 Oct 2014 20:25:04 +0300 > > "Michael S. Tsirkin" wrote: > > > [...] > > > > > > BTW I reverted that patch, and to fix migration, I'm thinking > > > about app

Re: [Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-10-13 Thread Michael S. Tsirkin
On Mon, Oct 13, 2014 at 10:49:41AM +0200, Greg Kurz wrote: > On Mon, 6 Oct 2014 20:25:04 +0300 > "Michael S. Tsirkin" wrote: > > [...] > > > > BTW I reverted that patch, and to fix migration, I'm thinking > > about applying the following patch on top of master. > > > > Michael, > > I could for

Re: [Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-10-13 Thread Greg Kurz
On Mon, 6 Oct 2014 20:25:04 +0300 "Michael S. Tsirkin" wrote: > [...] > > BTW I reverted that patch, and to fix migration, I'm thinking > about applying the following patch on top of master. > Michael, I could force the migration issue with a rhel65 guest thanks to the following patch, applied

Re: [Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-10-06 Thread Michael S. Tsirkin
On Mon, Oct 06, 2014 at 06:46:17PM +0200, Greg Kurz wrote: > On Mon, 6 Oct 2014 19:26:21 +0300 > "Michael S. Tsirkin" wrote: > > On Mon, Oct 06, 2014 at 04:51:35PM +0200, Greg Kurz wrote: > > > On Wed, 17 Sep 2014 20:39:25 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Wed, Sep 17, 201

Re: [Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-10-06 Thread Greg Kurz
On Mon, 6 Oct 2014 19:26:21 +0300 "Michael S. Tsirkin" wrote: > On Mon, Oct 06, 2014 at 04:51:35PM +0200, Greg Kurz wrote: > > On Wed, 17 Sep 2014 20:39:25 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Sep 17, 2014 at 07:21:09PM +0200, Greg Kurz wrote: > > > > On Sun, 14 Sep 2014 21:30

Re: [Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-10-06 Thread Michael S. Tsirkin
On Mon, Oct 06, 2014 at 04:51:35PM +0200, Greg Kurz wrote: > On Wed, 17 Sep 2014 20:39:25 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Sep 17, 2014 at 07:21:09PM +0200, Greg Kurz wrote: > > > On Sun, 14 Sep 2014 21:30:36 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > Current support

Re: [Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-10-06 Thread Greg Kurz
On Wed, 17 Sep 2014 20:39:25 +0300 "Michael S. Tsirkin" wrote: > On Wed, Sep 17, 2014 at 07:21:09PM +0200, Greg Kurz wrote: > > On Sun, 14 Sep 2014 21:30:36 +0300 > > "Michael S. Tsirkin" wrote: > > > > > Current support for bus master (clearing OK bit) > > > together with the need to support g

Re: [Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-09-17 Thread Michael S. Tsirkin
On Wed, Sep 17, 2014 at 07:21:09PM +0200, Greg Kurz wrote: > On Sun, 14 Sep 2014 21:30:36 +0300 > "Michael S. Tsirkin" wrote: > > > Current support for bus master (clearing OK bit) > > together with the need to support guests which do not > > enable PCI bus mastering, leads to extra state in > >

Re: [Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-09-17 Thread Greg Kurz
On Sun, 14 Sep 2014 21:30:36 +0300 "Michael S. Tsirkin" wrote: > Current support for bus master (clearing OK bit) > together with the need to support guests which do not > enable PCI bus mastering, leads to extra state in > VIRTIO_PCI_FLAG_BUS_MASTER_BUG bit, which isn't robust > in case of cross

[Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-09-14 Thread Michael S. Tsirkin
Current support for bus master (clearing OK bit) together with the need to support guests which do not enable PCI bus mastering, leads to extra state in VIRTIO_PCI_FLAG_BUS_MASTER_BUG bit, which isn't robust in case of cross-version migration for the case when guests use the device before setting D