Re: [Qemu-devel] [PATCH] virtio-net: unbreak the minix guest

2013-04-25 Thread Jason Wang
On 04/25/2013 02:57 PM, Michael S. Tsirkin wrote: > On Thu, Apr 25, 2013 at 02:19:53PM +0800, Jason Wang wrote: >> Multiqueue patchset conditionally add control vq only when guest negotiate >> the >> feature. Though the spec is not clear on this but it breaks the minix guest >> since it will ident

Re: [Qemu-devel] [PATCH] virtio-net: unbreak the minix guest

2013-04-24 Thread Michael S. Tsirkin
On Thu, Apr 25, 2013 at 02:19:53PM +0800, Jason Wang wrote: > Multiqueue patchset conditionally add control vq only when guest negotiate the > feature. Though the spec is not clear on this but it breaks the minix guest > since it will identify the ctrl vq even if it does not support it. Though this

[Qemu-devel] [PATCH] virtio-net: unbreak the minix guest

2013-04-24 Thread Jason Wang
Multiqueue patchset conditionally add control vq only when guest negotiate the feature. Though the spec is not clear on this but it breaks the minix guest since it will identify the ctrl vq even if it does not support it. Though this behavior seems a violation on the spec "If the VIRTIO_NET_F_CTRL_