Re: [Qemu-devel] [PATCH] virtio-net: announce self by guest

2014-05-19 Thread Jason Wang
On 05/19/2014 06:06 PM, Michael S. Tsirkin wrote: > On Mon, May 19, 2014 at 05:34:38PM +0800, Jason Wang wrote: >> > On 05/18/2014 05:04 PM, Michael S. Tsirkin wrote: >>> > > On Fri, May 16, 2014 at 01:02:51PM +0800, Jason Wang wrote: > >> On 05/15/2014 05:45 PM, Michael S. Tsirkin wrote:

Re: [Qemu-devel] [PATCH] virtio-net: announce self by guest

2014-05-19 Thread Michael S. Tsirkin
On Mon, May 19, 2014 at 05:34:38PM +0800, Jason Wang wrote: > On 05/18/2014 05:04 PM, Michael S. Tsirkin wrote: > > On Fri, May 16, 2014 at 01:02:51PM +0800, Jason Wang wrote: > >> On 05/15/2014 05:45 PM, Michael S. Tsirkin wrote: > >>> On Thu, May 15, 2014 at 05:22:28PM +0800, Jason Wang wrote: >

Re: [Qemu-devel] [PATCH] virtio-net: announce self by guest

2014-05-19 Thread Jason Wang
On 05/18/2014 05:04 PM, Michael S. Tsirkin wrote: > On Fri, May 16, 2014 at 01:02:51PM +0800, Jason Wang wrote: >> On 05/15/2014 05:45 PM, Michael S. Tsirkin wrote: >>> On Thu, May 15, 2014 at 05:22:28PM +0800, Jason Wang wrote: On 05/15/2014 04:28 PM, Michael S. Tsirkin wrote: > Thanks, l

Re: [Qemu-devel] [PATCH] virtio-net: announce self by guest

2014-05-18 Thread Michael S. Tsirkin
On Fri, May 16, 2014 at 01:02:51PM +0800, Jason Wang wrote: > On 05/15/2014 05:45 PM, Michael S. Tsirkin wrote: > > On Thu, May 15, 2014 at 05:22:28PM +0800, Jason Wang wrote: > >> On 05/15/2014 04:28 PM, Michael S. Tsirkin wrote: > >>> Thanks, looks good. > >>> Some minor comments below, > >>> > >

Re: [Qemu-devel] [PATCH] virtio-net: announce self by guest

2014-05-15 Thread Jason Wang
On 05/15/2014 05:45 PM, Michael S. Tsirkin wrote: > On Thu, May 15, 2014 at 05:22:28PM +0800, Jason Wang wrote: >> On 05/15/2014 04:28 PM, Michael S. Tsirkin wrote: >>> Thanks, looks good. >>> Some minor comments below, >>> >>> On Thu, May 15, 2014 at 03:16:47PM +0800, Jason Wang wrote: It's h

Re: [Qemu-devel] [PATCH] virtio-net: announce self by guest

2014-05-15 Thread Michael S. Tsirkin
On Thu, May 15, 2014 at 05:22:28PM +0800, Jason Wang wrote: > On 05/15/2014 04:28 PM, Michael S. Tsirkin wrote: > > Thanks, looks good. > > Some minor comments below, > > > > On Thu, May 15, 2014 at 03:16:47PM +0800, Jason Wang wrote: > >> It's hard to track all mac addresses and their configuratio

Re: [Qemu-devel] [PATCH] virtio-net: announce self by guest

2014-05-15 Thread Jason Wang
On 05/15/2014 04:28 PM, Michael S. Tsirkin wrote: > Thanks, looks good. > Some minor comments below, > > On Thu, May 15, 2014 at 03:16:47PM +0800, Jason Wang wrote: >> It's hard to track all mac addresses and their configurations (e.g >> vlan or ipv6) in qemu. Without those informations, it's impos

Re: [Qemu-devel] [PATCH] virtio-net: announce self by guest

2014-05-15 Thread Michael S. Tsirkin
Thanks, looks good. Some minor comments below, On Thu, May 15, 2014 at 03:16:47PM +0800, Jason Wang wrote: > It's hard to track all mac addresses and their configurations (e.g > vlan or ipv6) in qemu. Without those informations, it's impossible to s/those informations/this information/ > build p

[Qemu-devel] [PATCH] virtio-net: announce self by guest

2014-05-15 Thread Jason Wang
It's hard to track all mac addresses and their configurations (e.g vlan or ipv6) in qemu. Without those informations, it's impossible to build proper garp packet after migration. The only possible solution to this is let guest (who knew all configurations) to do this. So, this patch introduces a n