Re: [Qemu-devel] [PATCH] virtio-net: add feature bit for any header s/g

2013-07-11 Thread Laszlo Ersek
On 07/11/13 15:41, Michael S. Tsirkin wrote: > So we'll add a way for users to shoot themselves in the foot > by setting a flag incorrectly. Point being? Point taken. The flag name being global / universal relates to the concept, not support level. Exposing it in any device enables the user to se

Re: [Qemu-devel] [PATCH] virtio-net: add feature bit for any header s/g

2013-07-11 Thread Michael S. Tsirkin
On Thu, Jul 11, 2013 at 03:39:42PM +0200, Laszlo Ersek wrote: > On 07/11/13 15:15, Michael S. Tsirkin wrote: > > Old qemu versions required that 1st s/g entry is the header. > > > > Since QEMU 1.5, patchset titled "virtio-net: iovec handling cleanup" > > removed this limitation but a feature bit i

Re: [Qemu-devel] [PATCH] virtio-net: add feature bit for any header s/g

2013-07-11 Thread Laszlo Ersek
On 07/11/13 15:15, Michael S. Tsirkin wrote: > Old qemu versions required that 1st s/g entry is the header. > > Since QEMU 1.5, patchset titled "virtio-net: iovec handling cleanup" > removed this limitation but a feature bit is needed so guests know it's > safe to lay out header differently. > >

[Qemu-devel] [PATCH] virtio-net: add feature bit for any header s/g

2013-07-11 Thread Michael S. Tsirkin
Old qemu versions required that 1st s/g entry is the header. Since QEMU 1.5, patchset titled "virtio-net: iovec handling cleanup" removed this limitation but a feature bit is needed so guests know it's safe to lay out header differently. This patch applies on top and adds such a feature bit to QE