Re: [Qemu-devel] [PATCH] virtio-mmio: Always compile debug prints

2019-04-30 Thread LI, BO XUAN
Hi Eric and Phil, Thanks for your reviews. I am looking into trace events and I'll send a patch v2 soon. Eric Blake 於 2019年4月30日週二 下午11:03寫道: > On 4/30/19 5:15 AM, Philippe Mathieu-Daudé wrote: > > Hi Li, > > > > On 4/28/19 1:02 PM, Boxuan Li wrote: > >> Wrap printf calls inside debug macros (D

Re: [Qemu-devel] [PATCH] virtio-mmio: Always compile debug prints

2019-04-30 Thread Eric Blake
On 4/30/19 5:15 AM, Philippe Mathieu-Daudé wrote: > Hi Li, > > On 4/28/19 1:02 PM, Boxuan Li wrote: >> Wrap printf calls inside debug macros (DPRINTF) in `if` statement, and >> change output to stderr as well. This will ensure that printf function >> will always compile and prevent bitrot of the f

Re: [Qemu-devel] [PATCH] virtio-mmio: Always compile debug prints

2019-04-30 Thread Philippe Mathieu-Daudé
Hi Li, On 4/28/19 1:02 PM, Boxuan Li wrote: > Wrap printf calls inside debug macros (DPRINTF) in `if` statement, and > change output to stderr as well. This will ensure that printf function > will always compile and prevent bitrot of the format strings. There is an effort in QEMU to replace the o

[Qemu-devel] [PATCH] virtio-mmio: Always compile debug prints

2019-04-28 Thread Boxuan Li
Wrap printf calls inside debug macros (DPRINTF) in `if` statement, and change output to stderr as well. This will ensure that printf function will always compile and prevent bitrot of the format strings. Signed-off-by: Boxuan Li --- hw/virtio/virtio-mmio.c | 17 - 1 file changed,