Re: [Qemu-devel] [PATCH] virtio-crypto: fix virtio_queue_set_notification() race

2016-11-16 Thread Gonglei (Arei)
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > Sent: Thursday, November 17, 2016 4:18 AM > To: qemu-devel@nongnu.org > Cc: Gonglei (Arei); Michael S. Tsirkin; Stefan Hajnoczi > Subject: [PATCH] virtio-crypto: fix virtio_queue_set_notification() race > > We

[Qemu-devel] [PATCH] virtio-crypto: fix virtio_queue_set_notification() race

2016-11-16 Thread Stefan Hajnoczi
We must check for new virtqueue buffers after re-enabling notifications. This prevents the race condition where the guest added buffers just after we stopped popping the virtqueue but before we re-enabled notifications. I think the virtio-crypto code was based on virtio-net but this crucial detail