Re: [Qemu-devel] [PATCH] virtio-bus: Plug devices after features are negotiated

2016-09-13 Thread Maxime Coquelin
On 09/13/2016 10:59 AM, Cornelia Huck wrote: On Tue, 13 Sep 2016 09:08:04 +0200 Maxime Coquelin wrote: On 09/12/2016 09:58 PM, Michael S. Tsirkin wrote: On Mon, Sep 12, 2016 at 08:22:50PM +0200, Maxime Coquelin wrote: On 09/12/2016 10:51 AM, Cornelia Huck wrote: On Sat, 10 Sep 2016 10:2

Re: [Qemu-devel] [PATCH] virtio-bus: Plug devices after features are negotiated

2016-09-13 Thread Cornelia Huck
On Tue, 13 Sep 2016 09:08:04 +0200 Maxime Coquelin wrote: > On 09/12/2016 09:58 PM, Michael S. Tsirkin wrote: > > On Mon, Sep 12, 2016 at 08:22:50PM +0200, Maxime Coquelin wrote: > >> > >> > >> On 09/12/2016 10:51 AM, Cornelia Huck wrote: > >>> On Sat, 10 Sep 2016 10:23:37 +0200 > >>> Maxime Coqu

Re: [Qemu-devel] [PATCH] virtio-bus: Plug devices after features are negotiated

2016-09-13 Thread Marcel Apfelbaum
On 09/10/2016 11:23 AM, Maxime Coquelin wrote: Currently, devices are plugged before features are negotiated. If the backend doesn't support VIRTIO_F_VERSION_1, the transport need to rewind some settings. This is the case for CCW, for which a post_plugged callback had been introduced, where max_

Re: [Qemu-devel] [PATCH] virtio-bus: Plug devices after features are negotiated

2016-09-13 Thread Maxime Coquelin
On 09/12/2016 09:58 PM, Michael S. Tsirkin wrote: On Mon, Sep 12, 2016 at 08:22:50PM +0200, Maxime Coquelin wrote: On 09/12/2016 10:51 AM, Cornelia Huck wrote: On Sat, 10 Sep 2016 10:23:37 +0200 Maxime Coquelin wrote: Currently, devices are plugged before features are negotiated. If the

Re: [Qemu-devel] [PATCH] virtio-bus: Plug devices after features are negotiated

2016-09-12 Thread Maxime Coquelin
On 09/12/2016 08:41 PM, Eric Blake wrote: On 09/10/2016 03:23 AM, Maxime Coquelin wrote: Currently, devices are plugged before features are negotiated. If the backend doesn't support VIRTIO_F_VERSION_1, the transport need to rewind some settings. This is the case for CCW, for which a post_plu

Re: [Qemu-devel] [PATCH] virtio-bus: Plug devices after features are negotiated

2016-09-12 Thread Michael S. Tsirkin
On Mon, Sep 12, 2016 at 08:22:50PM +0200, Maxime Coquelin wrote: > > > On 09/12/2016 10:51 AM, Cornelia Huck wrote: > > On Sat, 10 Sep 2016 10:23:37 +0200 > > Maxime Coquelin wrote: > > > > > > Currently, devices are plugged before features are negotiated. > > > > If the backend doesn't support

Re: [Qemu-devel] [PATCH] virtio-bus: Plug devices after features are negotiated

2016-09-12 Thread Eric Blake
On 09/10/2016 03:23 AM, Maxime Coquelin wrote: > Currently, devices are plugged before features are negotiated. > If the backend doesn't support VIRTIO_F_VERSION_1, the transport > need to rewind some settings. > > This is the case for CCW, for which a post_plugged callback had > been introduced,

Re: [Qemu-devel] [PATCH] virtio-bus: Plug devices after features are negotiated

2016-09-12 Thread Maxime Coquelin
On 09/12/2016 10:51 AM, Cornelia Huck wrote: On Sat, 10 Sep 2016 10:23:37 +0200 Maxime Coquelin wrote: > Currently, devices are plugged before features are negotiated. > If the backend doesn't support VIRTIO_F_VERSION_1, the transport > need to rewind some settings. > > This is the case for

Re: [Qemu-devel] [PATCH] virtio-bus: Plug devices after features are negotiated

2016-09-12 Thread Cornelia Huck
On Mon, 12 Sep 2016 11:18:52 +0200 Maxime Coquelin wrote: > On 09/12/2016 10:51 AM, Cornelia Huck wrote: > > On Sat, 10 Sep 2016 10:23:37 +0200 > > Maxime Coquelin wrote: > >> diff --git a/include/hw/virtio/virtio-bus.h > >> b/include/hw/virtio/virtio-bus.h > >> index f3e5ef3..24caa0a 100644 >

Re: [Qemu-devel] [PATCH] virtio-bus: Plug devices after features are negotiated

2016-09-12 Thread Maxime Coquelin
On 09/12/2016 10:51 AM, Cornelia Huck wrote: On Sat, 10 Sep 2016 10:23:37 +0200 Maxime Coquelin wrote: Currently, devices are plugged before features are negotiated. If the backend doesn't support VIRTIO_F_VERSION_1, the transport need to rewind some settings. This is the case for CCW, for

Re: [Qemu-devel] [PATCH] virtio-bus: Plug devices after features are negotiated

2016-09-12 Thread Cornelia Huck
On Sat, 10 Sep 2016 10:23:37 +0200 Maxime Coquelin wrote: > Currently, devices are plugged before features are negotiated. > If the backend doesn't support VIRTIO_F_VERSION_1, the transport > need to rewind some settings. > > This is the case for CCW, for which a post_plugged callback had > been

Re: [Qemu-devel] [PATCH] virtio-bus: Plug devices after features are negotiated

2016-09-10 Thread Maxime Coquelin
On 09/10/2016 11:49 AM, Paolo Bonzini wrote: On 10/09/2016 10:23, Maxime Coquelin wrote: Currently, devices are plugged before features are negotiated. If the backend doesn't support VIRTIO_F_VERSION_1, the transport need to rewind some settings. This is the case for CCW, for which a post_p

Re: [Qemu-devel] [PATCH] virtio-bus: Plug devices after features are negotiated

2016-09-10 Thread Paolo Bonzini
On 10/09/2016 10:23, Maxime Coquelin wrote: > Currently, devices are plugged before features are negotiated. > If the backend doesn't support VIRTIO_F_VERSION_1, the transport > need to rewind some settings. > > This is the case for CCW, for which a post_plugged callback had > been introduced, w

[Qemu-devel] [PATCH] virtio-bus: Plug devices after features are negotiated

2016-09-10 Thread Maxime Coquelin
Currently, devices are plugged before features are negotiated. If the backend doesn't support VIRTIO_F_VERSION_1, the transport need to rewind some settings. This is the case for CCW, for which a post_plugged callback had been introduced, where max_rev field is just updated if VIRTIO_F_VERSION_1 i