Re: [Qemu-devel] [PATCH] virtio-blk: assert on starting/stopping

2016-04-04 Thread Michael S. Tsirkin
On Mon, Apr 04, 2016 at 10:25:34AM +0200, Cornelia Huck wrote: > On Mon, 4 Apr 2016 10:19:42 +0200 > Paolo Bonzini wrote: > > > On 04/04/2016 10:10, Cornelia Huck wrote: > > > > This will be fixed by Cornelia's rework, and is an example of why I > > > > think patch 1/9 is a good idea (IOW, assign

Re: [Qemu-devel] [PATCH] virtio-blk: assert on starting/stopping

2016-04-04 Thread Cornelia Huck
On Mon, 4 Apr 2016 10:19:42 +0200 Paolo Bonzini wrote: > On 04/04/2016 10:10, Cornelia Huck wrote: > > > This will be fixed by Cornelia's rework, and is an example of why I > > > think patch 1/9 is a good idea (IOW, assign=false is harmful). > > > > So what do we want to do for 2.6? The aio hand

Re: [Qemu-devel] [PATCH] virtio-blk: assert on starting/stopping

2016-04-04 Thread Paolo Bonzini
On 04/04/2016 10:10, Cornelia Huck wrote: > > This will be fixed by Cornelia's rework, and is an example of why I > > think patch 1/9 is a good idea (IOW, assign=false is harmful). > > So what do we want to do for 2.6? The aio handler rework (without the > cleanup) is needed. Do we want to inclu

Re: [Qemu-devel] [PATCH] virtio-blk: assert on starting/stopping

2016-04-04 Thread Cornelia Huck
On Sun, 3 Apr 2016 23:13:28 +0200 Paolo Bonzini wrote: > On 03/04/2016 21:59, Christian Borntraeger wrote: > > Thread 1 (Thread 0x3ffad25bb90 (LWP 41685)): > > ---Type to continue, or q to quit--- > > #0 0x03ffab5be2c0 in raise () at /lib64/libc.so.6 > > #1 0x03ffab5bfc26 in abort ()

Re: [Qemu-devel] [PATCH] virtio-blk: assert on starting/stopping

2016-04-03 Thread Paolo Bonzini
On 03/04/2016 21:59, Christian Borntraeger wrote: > Thread 1 (Thread 0x3ffad25bb90 (LWP 41685)): > ---Type to continue, or q to quit--- > #0 0x03ffab5be2c0 in raise () at /lib64/libc.so.6 > #1 0x03ffab5bfc26 in abort () at /lib64/libc.so.6 > #2 0x03ffab5b5bce in __assert_fail_bas

Re: [Qemu-devel] [PATCH] virtio-blk: assert on starting/stopping

2016-04-03 Thread Christian Borntraeger
On 04/03/2016 12:37 PM, Michael S. Tsirkin wrote: > Reentrancy cannot happen while the BQL is being held, > so we should never enter this condition. > > Cc: Christian Borntraeger > Cc: Cornelia Huck > Cc: Paolo Bonzini > Signed-off-by: Michael S. Tsirkin > --- > > This is a replacement for [P

[Qemu-devel] [PATCH] virtio-blk: assert on starting/stopping

2016-04-03 Thread Michael S. Tsirkin
Reentrancy cannot happen while the BQL is being held, so we should never enter this condition. Cc: Christian Borntraeger Cc: Cornelia Huck Cc: Paolo Bonzini Signed-off-by: Michael S. Tsirkin --- This is a replacement for [PATCH 9/9] virtio: remove starting/stopping checks Christian, could you