Re: [Qemu-devel] [PATCH] virtio-blk: Remove stale comment about draining

2016-08-01 Thread Fam Zheng
On Mon, 08/01 15:45, Laszlo Ersek wrote: > The thing I mildly dislike about patches that consist purely of code > removal is that they don't show up in "git blame", so it's hard to get > credit for them :) Which is a shame, beacuse code deletion is the best > kind of patch! :) I can't agree more!

Re: [Qemu-devel] [PATCH] virtio-blk: Remove stale comment about draining

2016-08-01 Thread Laszlo Ersek
On 08/01/16 04:53, Fam Zheng wrote: > This is stale after commit 6e40b3bf (virtio-blk: Use blk_drain() to > drain IO requests), remove it. > > Suggested-by: Laszlo Ersek > Signed-off-by: Fam Zheng > --- > hw/block/virtio-blk.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/hw/bloc

Re: [Qemu-devel] [PATCH] virtio-blk: Remove stale comment about draining

2016-07-31 Thread Fam Zheng
On Mon, 08/01 10:53, Fam Zheng wrote: > This is stale after commit 6e40b3bf (virtio-blk: Use blk_drain() to > drain IO requests), remove it. > > Suggested-by: Laszlo Ersek > Signed-off-by: Fam Zheng > --- Forgot to say, this applies on top of [Qemu-devel] [PATCH] virtio-blk: Release s->rq queu

[Qemu-devel] [PATCH] virtio-blk: Remove stale comment about draining

2016-07-31 Thread Fam Zheng
This is stale after commit 6e40b3bf (virtio-blk: Use blk_drain() to drain IO requests), remove it. Suggested-by: Laszlo Ersek Signed-off-by: Fam Zheng --- hw/block/virtio-blk.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index 89eca65..34