Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-29 Thread Michael S. Tsirkin
> I need a Signed-off-by so why don't you just go ahead and send a v2 and > I'll test that. OK I sent a v2 which is this fixup + the original patch smashed together.

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-29 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Thu, Nov 29, 2012 at 06:34:46PM +0530, Amit Shah wrote: >> On (Wed) 28 Nov 2012 [23:53:08], Michael S. Tsirkin wrote: >> > On Tue, Nov 27, 2012 at 06:25:04PM +0200, Michael S. Tsirkin wrote: >> > > On Thu, Nov 01, 2012 at 06:07:21PM +0200, Michael S. Tsirkin wrot

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-29 Thread Michael S. Tsirkin
On Thu, Nov 29, 2012 at 06:34:46PM +0530, Amit Shah wrote: > On (Wed) 28 Nov 2012 [23:53:08], Michael S. Tsirkin wrote: > > On Tue, Nov 27, 2012 at 06:25:04PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Nov 01, 2012 at 06:07:21PM +0200, Michael S. Tsirkin wrote: > > > > Commit 0d8d7690850eb0cf2b

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-29 Thread Amit Shah
On (Wed) 28 Nov 2012 [23:53:08], Michael S. Tsirkin wrote: > On Tue, Nov 27, 2012 at 06:25:04PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 01, 2012 at 06:07:21PM +0200, Michael S. Tsirkin wrote: > > > Commit 0d8d7690850eb0cf2b2b60933cf47669a6b6f18f introduced > > > a regression in virtio-net

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-28 Thread Michael S. Tsirkin
On Tue, Nov 27, 2012 at 06:25:04PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 01, 2012 at 06:07:21PM +0200, Michael S. Tsirkin wrote: > > Commit 0d8d7690850eb0cf2b2b60933cf47669a6b6f18f introduced > > a regression in virtio-net performance because it looks > > into the ring aggressively while w

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-27 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Thu, Nov 01, 2012 at 06:07:21PM +0200, Michael S. Tsirkin wrote: >> Commit 0d8d7690850eb0cf2b2b60933cf47669a6b6f18f introduced >> a regression in virtio-net performance because it looks >> into the ring aggressively while we really only care >> about a single pac

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-27 Thread Edivaldo de Araujo Pereira
Dear friends, Please excuse-me for not reporting earlier... I confirm that the patch by Michael really fixes the problem I've reported. The regression has gone away when I used it, so I think it is good to be applied. Thanks, Edivaldo de Araújo Pereira --- Em ter, 27/11/12, Michael S. Tsirk

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-27 Thread Michael S. Tsirkin
On Thu, Nov 01, 2012 at 06:07:21PM +0200, Michael S. Tsirkin wrote: > Commit 0d8d7690850eb0cf2b2b60933cf47669a6b6f18f introduced > a regression in virtio-net performance because it looks > into the ring aggressively while we really only care > about a single packet worth of buffers. > To fix, add p

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-02 Thread Stefan Hajnoczi
On Fri, Nov 2, 2012 at 3:48 PM, Michael S. Tsirkin wrote: > On Fri, Nov 02, 2012 at 11:18:18AM +0100, Stefan Hajnoczi wrote: >> On Thu, Nov 1, 2012 at 5:07 PM, Michael S. Tsirkin wrote: >> > Commit 0d8d7690850eb0cf2b2b60933cf47669a6b6f18f introduced >> > a regression in virtio-net performance bec

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-02 Thread Michael S. Tsirkin
On Fri, Nov 02, 2012 at 11:18:18AM +0100, Stefan Hajnoczi wrote: > On Thu, Nov 1, 2012 at 5:07 PM, Michael S. Tsirkin wrote: > > Commit 0d8d7690850eb0cf2b2b60933cf47669a6b6f18f introduced > > a regression in virtio-net performance because it looks > > into the ring aggressively while we really onl

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-02 Thread Stefan Hajnoczi
On Thu, Nov 1, 2012 at 5:07 PM, Michael S. Tsirkin wrote: > Commit 0d8d7690850eb0cf2b2b60933cf47669a6b6f18f introduced > a regression in virtio-net performance because it looks > into the ring aggressively while we really only care > about a single packet worth of buffers. > To fix, add parameters

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-02 Thread Amit Shah
On (Thu) 01 Nov 2012 [18:07:21], Michael S. Tsirkin wrote: > Commit 0d8d7690850eb0cf2b2b60933cf47669a6b6f18f introduced > a regression in virtio-net performance because it looks > into the ring aggressively while we really only care > about a single packet worth of buffers. > To fix, add parameters

[Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-01 Thread Michael S. Tsirkin
Commit 0d8d7690850eb0cf2b2b60933cf47669a6b6f18f introduced a regression in virtio-net performance because it looks into the ring aggressively while we really only care about a single packet worth of buffers. To fix, add parameters limiting lookahead, and use in virtqueue_avail_bytes. Signed-off-by