Re: [Qemu-devel] [PATCH] virtio: force VIRTIO_F_IOMMU_PLATFORM

2017-01-20 Thread Michael S. Tsirkin
On Fri, Jan 20, 2017 at 11:28:53AM +0800, Jason Wang wrote: > > > On 2017年01月20日 06:27, Michael S. Tsirkin wrote: > > On Thu, Jan 19, 2017 at 11:12:21AM +0800, Jason Wang wrote: > > > > > > On 2017年01月19日 01:50, Michael S. Tsirkin wrote: > > > > On Wed, Jan 18, 2017 at 10:42:48AM +0800, Jason Wa

Re: [Qemu-devel] [PATCH] virtio: force VIRTIO_F_IOMMU_PLATFORM

2017-01-19 Thread Jason Wang
On 2017年01月20日 06:27, Michael S. Tsirkin wrote: On Thu, Jan 19, 2017 at 11:12:21AM +0800, Jason Wang wrote: On 2017年01月19日 01:50, Michael S. Tsirkin wrote: On Wed, Jan 18, 2017 at 10:42:48AM +0800, Jason Wang wrote: On 2017年01月17日 22:44, Michael S. Tsirkin wrote: On Tue, Jan 17, 2017 at 12

Re: [Qemu-devel] [PATCH] virtio: force VIRTIO_F_IOMMU_PLATFORM

2017-01-19 Thread Michael S. Tsirkin
On Thu, Jan 19, 2017 at 11:12:21AM +0800, Jason Wang wrote: > > > On 2017年01月19日 01:50, Michael S. Tsirkin wrote: > > On Wed, Jan 18, 2017 at 10:42:48AM +0800, Jason Wang wrote: > > > > > > On 2017年01月17日 22:44, Michael S. Tsirkin wrote: > > > > On Tue, Jan 17, 2017 at 12:01:00PM +0800, Jason Wa

Re: [Qemu-devel] [PATCH] virtio: force VIRTIO_F_IOMMU_PLATFORM

2017-01-18 Thread Jason Wang
On 2017年01月19日 01:50, Michael S. Tsirkin wrote: On Wed, Jan 18, 2017 at 10:42:48AM +0800, Jason Wang wrote: On 2017年01月17日 22:44, Michael S. Tsirkin wrote: On Tue, Jan 17, 2017 at 12:01:00PM +0800, Jason Wang wrote: We allow vhost to clear VIRITO_F_IOMMU_PLATFORM which is wrong since VIRTIO

Re: [Qemu-devel] [PATCH] virtio: force VIRTIO_F_IOMMU_PLATFORM

2017-01-18 Thread Michael S. Tsirkin
On Wed, Jan 18, 2017 at 10:42:48AM +0800, Jason Wang wrote: > > > On 2017年01月17日 22:44, Michael S. Tsirkin wrote: > > On Tue, Jan 17, 2017 at 12:01:00PM +0800, Jason Wang wrote: > > > We allow vhost to clear VIRITO_F_IOMMU_PLATFORM which is wrong since > > > VIRTIO_F_IOMMU_PLATFORM is mandatory f

Re: [Qemu-devel] [PATCH] virtio: force VIRTIO_F_IOMMU_PLATFORM

2017-01-17 Thread Jason Wang
On 2017年01月17日 22:44, Michael S. Tsirkin wrote: On Tue, Jan 17, 2017 at 12:01:00PM +0800, Jason Wang wrote: We allow vhost to clear VIRITO_F_IOMMU_PLATFORM which is wrong since VIRTIO_F_IOMMU_PLATFORM is mandatory for security. Fixing this by enforce it after vdc->get_features(). Signed-off-b

Re: [Qemu-devel] [PATCH] virtio: force VIRTIO_F_IOMMU_PLATFORM

2017-01-17 Thread Michael S. Tsirkin
On Tue, Jan 17, 2017 at 12:01:00PM +0800, Jason Wang wrote: > We allow vhost to clear VIRITO_F_IOMMU_PLATFORM which is wrong since > VIRTIO_F_IOMMU_PLATFORM is mandatory for security. Fixing this by > enforce it after vdc->get_features(). > > Signed-off-by: Jason Wang > --- > hw/virtio/virtio-bu

[Qemu-devel] [PATCH] virtio: force VIRTIO_F_IOMMU_PLATFORM

2017-01-16 Thread Jason Wang
We allow vhost to clear VIRITO_F_IOMMU_PLATFORM which is wrong since VIRTIO_F_IOMMU_PLATFORM is mandatory for security. Fixing this by enforce it after vdc->get_features(). Signed-off-by: Jason Wang --- hw/virtio/virtio-bus.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git