Re: [Qemu-devel] [PATCH] virtio: abort on fatal error instead of just exiting

2016-07-27 Thread Michael S. Tsirkin
On Tue, Jun 28, 2016 at 10:24:29AM +0200, Igor Mammedov wrote: > replace mainly useless exit(1) on fatal error path with > abort(), so that it would be possible to generate core > dump, that could be used to analyse cause of problem. > > Signed-off-by: Igor Mammedov I thought about this, and I'd

Re: [Qemu-devel] [PATCH] virtio: abort on fatal error instead of just exiting

2016-06-29 Thread Igor Mammedov
On Thu, 30 Jun 2016 07:12:08 +0200 Markus Armbruster wrote: > Igor Mammedov writes: > > > On Wed, 29 Jun 2016 14:49:59 +0200 > > Markus Armbruster wrote: > > > >> Igor Mammedov writes: > >> > >> > replace mainly useless exit(1) on fatal error path with > >> > abort(), so that it would be

Re: [Qemu-devel] [PATCH] virtio: abort on fatal error instead of just exiting

2016-06-29 Thread Markus Armbruster
Igor Mammedov writes: > On Wed, 29 Jun 2016 14:49:59 +0200 > Markus Armbruster wrote: > >> Igor Mammedov writes: >> >> > replace mainly useless exit(1) on fatal error path with >> > abort(), so that it would be possible to generate core >> > dump, that could be used to analyse cause of problem

Re: [Qemu-devel] [PATCH] virtio: abort on fatal error instead of just exiting

2016-06-29 Thread Igor Mammedov
On Wed, 29 Jun 2016 14:49:59 +0200 Markus Armbruster wrote: > Igor Mammedov writes: > > > replace mainly useless exit(1) on fatal error path with > > abort(), so that it would be possible to generate core > > dump, that could be used to analyse cause of problem. > > > > Signed-off-by: Igor Mamm

Re: [Qemu-devel] [PATCH] virtio: abort on fatal error instead of just exiting

2016-06-29 Thread Markus Armbruster
Igor Mammedov writes: > replace mainly useless exit(1) on fatal error path with > abort(), so that it would be possible to generate core > dump, that could be used to analyse cause of problem. > > Signed-off-by: Igor Mammedov > --- > hw/virtio/virtio.c | 24 > 1 file ch

Re: [Qemu-devel] [PATCH] virtio: abort on fatal error instead of just exiting

2016-06-28 Thread Cornelia Huck
On Tue, 28 Jun 2016 10:24:29 +0200 Igor Mammedov wrote: > replace mainly useless exit(1) on fatal error path with > abort(), so that it would be possible to generate core > dump, that could be used to analyse cause of problem. > > Signed-off-by: Igor Mammedov > --- > hw/virtio/virtio.c | 24 ++

Re: [Qemu-devel] [PATCH] virtio: abort on fatal error instead of just exiting

2016-06-28 Thread Greg Kurz
On Tue, 28 Jun 2016 10:24:29 +0200 Igor Mammedov wrote: > replace mainly useless exit(1) on fatal error path with > abort(), so that it would be possible to generate core > dump, that could be used to analyse cause of problem. > > Signed-off-by: Igor Mammedov > --- Makes sense indeed. Acked-b

[Qemu-devel] [PATCH] virtio: abort on fatal error instead of just exiting

2016-06-28 Thread Igor Mammedov
replace mainly useless exit(1) on fatal error path with abort(), so that it would be possible to generate core dump, that could be used to analyse cause of problem. Signed-off-by: Igor Mammedov --- hw/virtio/virtio.c | 24 1 file changed, 12 insertions(+), 12 deletions(-