Re: [Qemu-devel] [PATCH] virtio: Report real progress in VQ aio poll handler

2017-02-13 Thread Stefan Hajnoczi
On Thu, Feb 09, 2017 at 04:40:47PM +0800, Fam Zheng wrote: > In virtio_queue_host_notifier_aio_poll, not all "!virtio_queue_empty()" > cases are making true progress. > > Currently the offending one is virtio-scsi event queue, whose handler > does nothing if no event is pending. As a result aio_po

Re: [Qemu-devel] [PATCH] virtio: Report real progress in VQ aio poll handler

2017-02-09 Thread Paolo Bonzini
On 09/02/2017 09:40, Fam Zheng wrote: > In virtio_queue_host_notifier_aio_poll, not all "!virtio_queue_empty()" > cases are making true progress. > > Currently the offending one is virtio-scsi event queue, whose handler > does nothing if no event is pending. As a result aio_poll() will spin on >

Re: [Qemu-devel] [PATCH] virtio: Report real progress in VQ aio poll handler

2017-02-09 Thread Ed Swierk
On Thu, Feb 9, 2017 at 12:40 AM, Fam Zheng wrote: > In virtio_queue_host_notifier_aio_poll, not all "!virtio_queue_empty()" > cases are making true progress. > > Currently the offending one is virtio-scsi event queue, whose handler > does nothing if no event is pending. As a result aio_poll() will

[Qemu-devel] [PATCH] virtio: Report real progress in VQ aio poll handler

2017-02-09 Thread Fam Zheng
In virtio_queue_host_notifier_aio_poll, not all "!virtio_queue_empty()" cases are making true progress. Currently the offending one is virtio-scsi event queue, whose handler does nothing if no event is pending. As a result aio_poll() will spin on the "non-empty" VQ and take 100% host CPU. Fix thi