Re: [Qemu-devel] [PATCH] virtio: Register host notifier handler as external

2016-05-09 Thread Paolo Bonzini
On 21/04/2016 16:28, Fam Zheng wrote: >> > Is this the right thing to do in all cases? >> > E.g. it doesn't look like event_notifier_set_handler previously called >> > aio_set_event_notifier on win32. Was there a reason for this? > It's a good catch. I'm not sure whether/how win32 goes with ioeve

Re: [Qemu-devel] [PATCH] virtio: Register host notifier handler as external

2016-04-21 Thread Fam Zheng
On Thu, 04/21 10:04, Fam Zheng wrote: > This ensures the bdrv_drained_begin() in block layer is effective and > fixes launchpad bug #1570134. > > Signed-off-by: Fam Zheng > --- > hw/virtio/virtio.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/hw/virtio/virtio.

Re: [Qemu-devel] [PATCH] virtio: Register host notifier handler as external

2016-04-21 Thread Fam Zheng
On Thu, 04/21 15:20, Michael S. Tsirkin wrote: > On Thu, Apr 21, 2016 at 10:04:28AM +0800, Fam Zheng wrote: > > This ensures the bdrv_drained_begin() in block layer is effective and > > fixes launchpad bug #1570134. > > > > Signed-off-by: Fam Zheng > > --- > > hw/virtio/virtio.c | 7 --- > >

Re: [Qemu-devel] [PATCH] virtio: Register host notifier handler as external

2016-04-21 Thread Michael S. Tsirkin
On Thu, Apr 21, 2016 at 10:04:28AM +0800, Fam Zheng wrote: > This ensures the bdrv_drained_begin() in block layer is effective and > fixes launchpad bug #1570134. > > Signed-off-by: Fam Zheng > --- > hw/virtio/virtio.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --gi

[Qemu-devel] [PATCH] virtio: Register host notifier handler as external

2016-04-20 Thread Fam Zheng
This ensures the bdrv_drained_begin() in block layer is effective and fixes launchpad bug #1570134. Signed-off-by: Fam Zheng --- hw/virtio/virtio.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index f745c4a..002c2c6 100644 ---