Re: [Qemu-devel] [PATCH] virtio: Notice when the system doesn't support MSIx at all

2015-10-26 Thread Michael S. Tsirkin
On Mon, Oct 26, 2015 at 10:47:48AM +, Mark Cave-Ayland wrote: > On 26/10/15 10:14, Peter Maydell wrote: > > > On 26 October 2015 at 10:09, Mark Cave-Ayland > > wrote: > >> On 26/10/15 10:03, Michael S. Tsirkin wrote: > >>> Pls address the issues if you want this applied. > >> > >> The patch c

Re: [Qemu-devel] [PATCH] virtio: Notice when the system doesn't support MSIx at all

2015-10-26 Thread Mark Cave-Ayland
On 26/10/15 10:14, Peter Maydell wrote: > On 26 October 2015 at 10:09, Mark Cave-Ayland > wrote: >> On 26/10/15 10:03, Michael S. Tsirkin wrote: >>> Pls address the issues if you want this applied. >> >> The patch came from Richard rather than myself - my only involvement has >> been to champion

Re: [Qemu-devel] [PATCH] virtio: Notice when the system doesn't support MSIx at all

2015-10-26 Thread Michael S. Tsirkin
On Mon, Oct 26, 2015 at 10:14:20AM +, Peter Maydell wrote: > On 26 October 2015 at 10:09, Mark Cave-Ayland > wrote: > > On 26/10/15 10:03, Michael S. Tsirkin wrote: > >> Pls address the issues if you want this applied. > > > > The patch came from Richard rather than myself - my only involvemen

Re: [Qemu-devel] [PATCH] virtio: Notice when the system doesn't support MSIx at all

2015-10-26 Thread Peter Maydell
On 26 October 2015 at 10:09, Mark Cave-Ayland wrote: > On 26/10/15 10:03, Michael S. Tsirkin wrote: >> Pls address the issues if you want this applied. > > The patch came from Richard rather than myself - my only involvement has > been to champion the patch since both myself and Peter have had rep

Re: [Qemu-devel] [PATCH] virtio: Notice when the system doesn't support MSIx at all

2015-10-26 Thread Mark Cave-Ayland
On 26/10/15 10:03, Michael S. Tsirkin wrote: > On Mon, Oct 26, 2015 at 09:44:47AM +, Mark Cave-Ayland wrote: >> On 27/09/15 15:40, Peter Maydell wrote: >> >>> Ping^2 -- this is still confusing users, cf bug LP:1500175. >>> >>> thanks >>> -- PMM >>> >>> On 6 July 2015 at 11:38, Peter Maydell w

Re: [Qemu-devel] [PATCH] virtio: Notice when the system doesn't support MSIx at all

2015-10-26 Thread Michael S. Tsirkin
On Mon, Oct 26, 2015 at 09:44:47AM +, Mark Cave-Ayland wrote: > On 27/09/15 15:40, Peter Maydell wrote: > > > Ping^2 -- this is still confusing users, cf bug LP:1500175. > > > > thanks > > -- PMM > > > > On 6 July 2015 at 11:38, Peter Maydell wrote: > >> On 3 July 2015 at 09:22, Mark Cave-A

Re: [Qemu-devel] [PATCH] virtio: Notice when the system doesn't support MSIx at all

2015-10-26 Thread Mark Cave-Ayland
On 27/09/15 15:40, Peter Maydell wrote: > Ping^2 -- this is still confusing users, cf bug LP:1500175. > > thanks > -- PMM > > On 6 July 2015 at 11:38, Peter Maydell wrote: >> On 3 July 2015 at 09:22, Mark Cave-Ayland >> wrote: >>> On 19/05/15 21:29, Richard Henderson wrote: >>> And do no

Re: [Qemu-devel] [PATCH] virtio: Notice when the system doesn't support MSIx at all

2015-09-27 Thread Peter Maydell
Ping^2 -- this is still confusing users, cf bug LP:1500175. thanks -- PMM On 6 July 2015 at 11:38, Peter Maydell wrote: > On 3 July 2015 at 09:22, Mark Cave-Ayland > wrote: >> On 19/05/15 21:29, Richard Henderson wrote: >> >>> And do not issue an error_report in that case. >>> >>> Signed-off-b

Re: [Qemu-devel] [PATCH] virtio: Notice when the system doesn't support MSIx at all

2015-07-06 Thread Peter Maydell
On 3 July 2015 at 09:22, Mark Cave-Ayland wrote: > On 19/05/15 21:29, Richard Henderson wrote: > >> And do not issue an error_report in that case. >> >> Signed-off-by: Richard Henderson >> --- >> hw/virtio/virtio-pci.c | 15 ++- >> 1 file changed, 10 insertions(+), 5 deletions(-) >>

Re: [Qemu-devel] [PATCH] virtio: Notice when the system doesn't support MSIx at all

2015-07-03 Thread Mark Cave-Ayland
On 19/05/15 21:29, Richard Henderson wrote: > And do not issue an error_report in that case. > > Signed-off-by: Richard Henderson > --- > hw/virtio/virtio-pci.c | 15 ++- > 1 file changed, 10 insertions(+), 5 deletions(-) > -- > > This seems to be about the only sane way to test th

Re: [Qemu-devel] [PATCH] virtio: Notice when the system doesn't support MSIx at all

2015-05-21 Thread Mark Cave-Ayland
On 20/05/15 16:10, Richard Henderson wrote: > On 05/20/2015 02:59 AM, Michael S. Tsirkin wrote: >> On Tue, May 19, 2015 at 01:29:51PM -0700, Richard Henderson wrote: >>> And do not issue an error_report in that case. >>> >>> Signed-off-by: Richard Henderson >>> --- >>> hw/virtio/virtio-pci.c | 1

Re: [Qemu-devel] [PATCH] virtio: Notice when the system doesn't support MSIx at all

2015-05-20 Thread Richard Henderson
On 05/20/2015 02:59 AM, Michael S. Tsirkin wrote: > On Tue, May 19, 2015 at 01:29:51PM -0700, Richard Henderson wrote: >> And do not issue an error_report in that case. >> >> Signed-off-by: Richard Henderson >> --- >> hw/virtio/virtio-pci.c | 15 ++- >> 1 file changed, 10 insertions(+

Re: [Qemu-devel] [PATCH] virtio: Notice when the system doesn't support MSIx at all

2015-05-20 Thread Michael S. Tsirkin
On Tue, May 19, 2015 at 01:29:51PM -0700, Richard Henderson wrote: > And do not issue an error_report in that case. > > Signed-off-by: Richard Henderson > --- > hw/virtio/virtio-pci.c | 15 ++- > 1 file changed, 10 insertions(+), 5 deletions(-) > -- > > This seems to be about the on

[Qemu-devel] [PATCH] virtio: Notice when the system doesn't support MSIx at all

2015-05-19 Thread Richard Henderson
And do not issue an error_report in that case. Signed-off-by: Richard Henderson --- hw/virtio/virtio-pci.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) -- This seems to be about the only sane way to test the value of msi_supported from here. Thoughts? r~ diff --g