Re: [Qemu-devel] [PATCH] virtio: Mark virtio-device as non-user-creatable

2017-08-03 Thread Halil Pasic
On 08/03/2017 04:45 PM, Eduardo Habkost wrote: > On Wed, Aug 02, 2017 at 02:33:00PM +0200, Halil Pasic wrote: >> >> >> On 08/02/2017 01:01 AM, Eduardo Habkost wrote: >>> TYPE_VIRTIO_DEVICE devices are already not usable with -device >>> and device_add, but they are reported as user-creatable on >

Re: [Qemu-devel] [PATCH] virtio: Mark virtio-device as non-user-creatable

2017-08-03 Thread Eduardo Habkost
On Wed, Aug 02, 2017 at 02:33:00PM +0200, Halil Pasic wrote: > > > On 08/02/2017 01:01 AM, Eduardo Habkost wrote: > > TYPE_VIRTIO_DEVICE devices are already not usable with -device > > and device_add, but they are reported as user-creatable on > > "-device help" and through monitor interfaces. >

Re: [Qemu-devel] [PATCH] virtio: Mark virtio-device as non-user-creatable

2017-08-02 Thread Eduardo Habkost
On Tue, Aug 01, 2017 at 08:01:55PM -0300, Eduardo Habkost wrote: > TYPE_VIRTIO_DEVICE devices are already not usable with -device > and device_add, but they are reported as user-creatable on > "-device help" and through monitor interfaces. > > Mark them as not user-creatable to avoid confusing use

Re: [Qemu-devel] [PATCH] virtio: Mark virtio-device as non-user-creatable

2017-08-02 Thread Halil Pasic
On 08/02/2017 01:01 AM, Eduardo Habkost wrote: > TYPE_VIRTIO_DEVICE devices are already not usable with -device > and device_add, but they are reported as user-creatable on > "-device help" and through monitor interfaces. I've tried -device virtio-rng on s390x and from what I see, it seems we 'a

[Qemu-devel] [PATCH] virtio: Mark virtio-device as non-user-creatable

2017-08-01 Thread Eduardo Habkost
TYPE_VIRTIO_DEVICE devices are already not usable with -device and device_add, but they are reported as user-creatable on "-device help" and through monitor interfaces. Mark them as not user-creatable to avoid confusing users, and to allow automated testing (e.g. scripts/device-crash-test) to skip