Re: [Qemu-devel] [PATCH] vhost_net: start/stop guest notifiers properly

2014-08-18 Thread Jason Wang
On 08/19/2014 03:53 AM, Michael S. Tsirkin wrote: > On Mon, Aug 18, 2014 at 05:51:31PM +0800, Jason Wang wrote: >> > commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue >> > support changed the order of stopping the device. Previously >> > vhost_dev_stop would disable backend and only

Re: [Qemu-devel] [PATCH] vhost_net: start/stop guest notifiers properly

2014-08-18 Thread Jason Wang
On 08/18/2014 09:20 PM, William Dauchy wrote: > On Mon, Aug 18, 2014 at 11:51 AM, Jason Wang wrote: >> err: >> @@ -254,16 +254,16 @@ void vhost_net_stop(VirtIODevice *dev, NetClientState >> *ncs, >> VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(vbus); >> int i, r; >> >> +for (i = 0; i <

Re: [Qemu-devel] [PATCH] vhost_net: start/stop guest notifiers properly

2014-08-18 Thread Jason Wang
On 08/18/2014 08:11 PM, Zhangjie (HZ) wrote: > On 2014/8/18 17:51, Jason Wang wrote: >> commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue >> support changed the order of stopping the device. Previously >> vhost_dev_stop would disable backend and only afterwards, unset guest >> notif

Re: [Qemu-devel] [PATCH] vhost_net: start/stop guest notifiers properly

2014-08-18 Thread Michael S. Tsirkin
On Mon, Aug 18, 2014 at 05:51:31PM +0800, Jason Wang wrote: > commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue > support changed the order of stopping the device. Previously > vhost_dev_stop would disable backend and only afterwards, unset guest > notifiers. We now unset guest noti

Re: [Qemu-devel] [PATCH] vhost_net: start/stop guest notifiers properly

2014-08-18 Thread William Dauchy
On Mon, Aug 18, 2014 at 11:51 AM, Jason Wang wrote: > err: > @@ -254,16 +254,16 @@ void vhost_net_stop(VirtIODevice *dev, NetClientState > *ncs, > VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(vbus); > int i, r; > > +for (i = 0; i < total_queues; i++) { > +vhost_net_stop_one(tap

Re: [Qemu-devel] [PATCH] vhost_net: start/stop guest notifiers properly

2014-08-18 Thread Zhangjie (HZ)
On 2014/8/18 17:51, Jason Wang wrote: > commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue > support changed the order of stopping the device. Previously > vhost_dev_stop would disable backend and only afterwards, unset guest > notifiers. We now unset guest notifiers while vhost is

[Qemu-devel] [PATCH] vhost_net: start/stop guest notifiers properly

2014-08-18 Thread Jason Wang
commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue support changed the order of stopping the device. Previously vhost_dev_stop would disable backend and only afterwards, unset guest notifiers. We now unset guest notifiers while vhost is still active. This can lose interrupts causing