Re: [Qemu-devel] [PATCH] vhost-user: fix VHOST_USER_SET_MEM_TABLE

2014-06-26 Thread Paolo Bonzini
Il 26/06/2014 11:10, Damjan Marion (damarion) ha scritto: Does it really make a sense to keep old broken code, which doesn’t work if VM have more than 3 GB of RAM? As Nikolay said yesterday: > On the other hand there's no wide adoption of > the protocol so it's still not critical to change it.

Re: [Qemu-devel] [PATCH] vhost-user: fix VHOST_USER_SET_MEM_TABLE

2014-06-26 Thread Damjan Marion (damarion)
On 26 Jun 2014, at 10:01, Michael S. Tsirkin wrote: > On Thu, Jun 26, 2014 at 09:55:03AM +0200, Damjan Marion wrote: >> Old code was affected by memory gaps which >> resulted in buffer pointers pointing to >> address outside of the mapped regions. >> >> Signed-off-by: Damjan Marion >> --- >> d

Re: [Qemu-devel] [PATCH] vhost-user: fix VHOST_USER_SET_MEM_TABLE

2014-06-26 Thread Michael S. Tsirkin
On Thu, Jun 26, 2014 at 09:55:03AM +0200, Damjan Marion wrote: > Old code was affected by memory gaps which > resulted in buffer pointers pointing to > address outside of the mapped regions. > > Signed-off-by: Damjan Marion > --- > docs/specs/vhost-user.txt | 7 --- > exec.c

[Qemu-devel] [PATCH] vhost-user: fix VHOST_USER_SET_MEM_TABLE

2014-06-26 Thread Damjan Marion
Old code was affected by memory gaps which resulted in buffer pointers pointing to address outside of the mapped regions. Signed-off-by: Damjan Marion --- docs/specs/vhost-user.txt | 7 --- exec.c| 7 +++ hw/virtio/vhost-user.c| 22 +- includ