Re: [Qemu-devel] [PATCH] vhost-user: avoid misaligned access

2018-03-20 Thread Michael S. Tsirkin
On Tue, Mar 20, 2018 at 08:05:38AM +0100, Igor Mammedov wrote: > On Tue, 20 Mar 2018 04:36:48 +0200 > "Michael S. Tsirkin" wrote: > > > On Tue, Mar 20, 2018 at 02:01:07AM +, Zhoujian (jay) wrote: > > > > > > > > > > -Original Message- > > > > From: Michael S. Tsirkin [mailto:m...@

Re: [Qemu-devel] [PATCH] vhost-user: avoid misaligned access

2018-03-20 Thread Igor Mammedov
On Tue, 20 Mar 2018 04:36:48 +0200 "Michael S. Tsirkin" wrote: > On Tue, Mar 20, 2018 at 02:01:07AM +, Zhoujian (jay) wrote: > > > > > > > -Original Message- > > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > > Sent: Saturday, March 17, 2018 2:20 AM > > > To: qemu-devel@n

Re: [Qemu-devel] [PATCH] vhost-user: avoid misaligned access

2018-03-19 Thread Michael S. Tsirkin
On Tue, Mar 20, 2018 at 02:01:07AM +, Zhoujian (jay) wrote: > > > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Saturday, March 17, 2018 2:20 AM > > To: qemu-devel@nongnu.org > > Cc: Zhoujian (jay) > > Subject: [PATCH] vhost-user: avoid misalign

Re: [Qemu-devel] [PATCH] vhost-user: avoid misaligned access

2018-03-19 Thread Zhoujian (jay)
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Saturday, March 17, 2018 2:20 AM > To: qemu-devel@nongnu.org > Cc: Zhoujian (jay) > Subject: [PATCH] vhost-user: avoid misaligned access > > We can't pass a pointer to memory field directly since it's withi

[Qemu-devel] [PATCH] vhost-user: avoid misaligned access

2018-03-16 Thread Michael S. Tsirkin
We can't pass a pointer to memory field directly since it's within a packed structure, so isn't aligned. Pass a pointer on stack and copy. Fixes: 30c4cc7 ("vhost: used_memslots refactoring") Cc: Jay Zhou Signed-off-by: Michael S. Tsirkin --- I had to apply this to fix make check errors with cla