Re: [Qemu-devel] [PATCH] vhost-blk: turn on pre-defined RO feature bit

2018-05-27 Thread Liu, Changpeng
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > Sent: Friday, May 25, 2018 6:20 PM > To: Liu, Changpeng > Cc: qemu-devel@nongnu.org; m...@redhat.com > Subject: Re: [PATCH] vhost-blk: turn on pre-defined RO feature bit > > On Tue, May 22, 2018 at 02:39:28PM +0

Re: [Qemu-devel] [PATCH] vhost-blk: turn on pre-defined RO feature bit

2018-05-25 Thread Stefan Hajnoczi
On Tue, May 22, 2018 at 02:39:28PM +, Liu, Changpeng wrote: > > > > -Original Message- > > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > > Sent: Tuesday, May 22, 2018 6:11 AM > > To: Liu, Changpeng > > Cc: qemu-devel@nongnu.org; m...@redhat.com > > Subject: Re: [PATCH] vhost-b

Re: [Qemu-devel] [PATCH] vhost-blk: turn on pre-defined RO feature bit

2018-05-22 Thread Liu, Changpeng
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > Sent: Tuesday, May 22, 2018 6:11 AM > To: Liu, Changpeng > Cc: qemu-devel@nongnu.org; m...@redhat.com > Subject: Re: [PATCH] vhost-blk: turn on pre-defined RO feature bit > > On Sat, May 19, 2018 at 06:20:16AM +

Re: [Qemu-devel] [PATCH] vhost-blk: turn on pre-defined RO feature bit

2018-05-22 Thread Stefan Hajnoczi
On Sat, May 19, 2018 at 06:20:16AM +0800, Changpeng Liu wrote: > Read only feature shouldn't be negotiable, because if the > backend device reported Read only feature supported, QEMU > host driver shouldn't change backend's RO attribute. I don't understand this patch. Does it make *all* virtio-bl

[Qemu-devel] [PATCH] vhost-blk: turn on pre-defined RO feature bit

2018-05-18 Thread Changpeng Liu
Read only feature shouldn't be negotiable, because if the backend device reported Read only feature supported, QEMU host driver shouldn't change backend's RO attribute. Signed-off-by: Changpeng Liu --- hw/block/vhost-user-blk.c | 5 + include/hw/virtio/vhost-user-blk.h | 1 - 2 file