Re: [Qemu-devel] [PATCH] vhost: secure vhost shared log files using argv paremeter

2016-11-08 Thread Rafael David Tinoco
Hello, > On Tue, Nov 8, 2016 at 4:49 PM Rafael David Tinoco > wrote: > Hello Michael, André, > > Could you do a quick review before a final submission ? > > http://paste.ubuntu.com/23446279/ > ... > (André) > Could it be only a filename? This would simplify testing. > (Michael) > When vhostlo

Re: [Qemu-devel] [PATCH] vhost: secure vhost shared log files using argv paremeter

2016-11-08 Thread Marc-André Lureau
Hi On Tue, Nov 8, 2016 at 4:49 PM Rafael David Tinoco < rafael.tin...@canonical.com> wrote: > Hello Michael, André, > > Could you do a quick review before a final submission ? > > http://paste.ubuntu.com/23446279/ > > - I split the commits into 1) bugfix, 2) new util with test, 3) vhostlog > > Th

Re: [Qemu-devel] [PATCH] vhost: secure vhost shared log files using argv paremeter

2016-11-08 Thread Rafael David Tinoco
Hello Michael, André, Could you do a quick review before a final submission ? http://paste.ubuntu.com/23446279/ - I split the commits into 1) bugfix, 2) new util with test, 3) vhostlog The unit test is testing passing fds between 2 processes and asserting contents of mmap buffer coming from the

Re: [Qemu-devel] [PATCH] vhost: secure vhost shared log files using argv paremeter

2016-10-31 Thread Michael S. Tsirkin
On Mon, Oct 31, 2016 at 08:35:33AM -0200, Rafael David Tinoco wrote: > On Sun, Oct 30, 2016 at 5:26 PM, Michael S. Tsirkin wrote: > > > > On Sat, Oct 22, 2016 at 07:00:41AM +, Rafael David Tinoco wrote: > > > Commit 31190ed7 added a migration blocker in vhost_dev_init() to > > > check if memfd

Re: [Qemu-devel] [PATCH] vhost: secure vhost shared log files using argv paremeter

2016-10-31 Thread Rafael David Tinoco
On Sun, Oct 30, 2016 at 5:26 PM, Michael S. Tsirkin wrote: > > On Sat, Oct 22, 2016 at 07:00:41AM +, Rafael David Tinoco wrote: > > Commit 31190ed7 added a migration blocker in vhost_dev_init() to > > check if memfd would succeed. It is better if this blocker first > > checks if vhost backend

Re: [Qemu-devel] [PATCH] vhost: secure vhost shared log files using argv paremeter

2016-10-30 Thread Michael S. Tsirkin
On Sat, Oct 22, 2016 at 07:00:41AM +, Rafael David Tinoco wrote: > Commit 31190ed7 added a migration blocker in vhost_dev_init() to > check if memfd would succeed. It is better if this blocker first > checks if vhost backend requires shared log. This will avoid a > situation where a blocker is

Re: [Qemu-devel] [PATCH] vhost: secure vhost shared log files using argv paremeter

2016-10-23 Thread Marc-André Lureau
- Original Message - > Commit 31190ed7 added a migration blocker in vhost_dev_init() to > check if memfd would succeed. It is better if this blocker first > checks if vhost backend requires shared log. This will avoid a > situation where a blocker is added inappropriately (e.g. shared > l

Re: [Qemu-devel] [PATCH] vhost: secure vhost shared log files using argv paremeter

2016-10-22 Thread Rafael David Tinoco
Hello, > On Oct 22, 2016, at 05:18, Marc-André Lureau > wrote: > > Hi > > On Sat, Oct 22, 2016 at 10:01 AM Rafael David Tinoco > wrote: > Commit 31190ed7 added a migration blocker in vhost_dev_init() to > check if memfd would succeed. It is better if this blocker first > checks if vhost back

[Qemu-devel] [PATCH] vhost: secure vhost shared log files using argv paremeter

2016-10-22 Thread Rafael David Tinoco
Commit 31190ed7 added a migration blocker in vhost_dev_init() to check if memfd would succeed. It is better if this blocker first checks if vhost backend requires shared log. This will avoid a situation where a blocker is added inappropriately (e.g. shared log allocation fails when vhost backend do

Re: [Qemu-devel] [PATCH] vhost: secure vhost shared log files using argv paremeter

2016-10-22 Thread Marc-André Lureau
Hi On Sat, Oct 22, 2016 at 10:01 AM Rafael David Tinoco < rafael.tin...@canonical.com> wrote: Commit 31190ed7 added a migration blocker in vhost_dev_init() to check if memfd would succeed. It is better if this blocker first checks if vhost backend requires shared log. This will avoid a situation

[Qemu-devel] [PATCH] vhost: secure vhost shared log files using argv paremeter

2016-10-22 Thread Rafael David Tinoco
Commit 31190ed7 added a migration blocker in vhost_dev_init() to check if memfd would succeed. It is better if this blocker first checks if vhost backend requires shared log. This will avoid a situation where a blocker is added inappropriately (e.g. shared log allocation fails when vhost backend do