Re: [Qemu-devel] [PATCH] vga: squash build error in vga_update_memory_access()

2011-08-24 Thread Anthony Liguori
On 08/24/2011 08:00 AM, Jan Kiszka wrote: On 2011-08-24 14:58, Avi Kivity wrote: On 08/24/2011 03:46 PM, Jan Kiszka wrote: +++ b/hw/vga.c @@ -179,6 +179,8 @@ static void vga_update_memory_access(VGACommonState *s) base = 0xb8000; size = 0x8000; b

Re: [Qemu-devel] [PATCH] vga: squash build error in vga_update_memory_access()

2011-08-24 Thread Avi Kivity
On 08/24/2011 04:00 PM, Jan Kiszka wrote: On 2011-08-24 14:58, Avi Kivity wrote: > On 08/24/2011 03:46 PM, Jan Kiszka wrote: >>> +++ b/hw/vga.c >>> @@ -179,6 +179,8 @@ static void vga_update_memory_access(VGACommonState *s) >>>base = 0xb8000; >>>size = 0x8000

Re: [Qemu-devel] [PATCH] vga: squash build error in vga_update_memory_access()

2011-08-24 Thread Jan Kiszka
On 2011-08-24 14:58, Avi Kivity wrote: > On 08/24/2011 03:46 PM, Jan Kiszka wrote: >>> +++ b/hw/vga.c >>> @@ -179,6 +179,8 @@ static void vga_update_memory_access(VGACommonState *s) >>> base = 0xb8000; >>> size = 0x8000; >>> break; >>> +default:

Re: [Qemu-devel] [PATCH] vga: squash build error in vga_update_memory_access()

2011-08-24 Thread Avi Kivity
On 08/24/2011 03:46 PM, Jan Kiszka wrote: > +++ b/hw/vga.c > @@ -179,6 +179,8 @@ static void vga_update_memory_access(VGACommonState *s) > base = 0xb8000; > size = 0x8000; > break; > +default: > +abort(); > } >

Re: [Qemu-devel] [PATCH] vga: squash build error in vga_update_memory_access()

2011-08-24 Thread Jan Kiszka
On 2011-08-24 14:07, Avi Kivity wrote: > Newer gcc complains that base and size may be used uninitialized, even though > it is clearly a false warning. Mmh, gcc is getting dumber again. > Silence the warning by indicating to gcc that > the code path triggering the warning cannot happen. > > Sig

[Qemu-devel] [PATCH] vga: squash build error in vga_update_memory_access()

2011-08-24 Thread Avi Kivity
Newer gcc complains that base and size may be used uninitialized, even though it is clearly a false warning. Silence the warning by indicating to gcc that the code path triggering the warning cannot happen. Signed-off-by: Avi Kivity --- hw/vga.c |2 ++ 1 files changed, 2 insertions(+), 0 de